From: Michael Heerdegen <michael_heerdegen@web.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: 13670@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug
Date: Sun, 01 May 2016 17:34:09 +0200 [thread overview]
Message-ID: <87eg9l3i8e.fsf@web.de> (raw)
In-Reply-To: <e9d3d52b-db93-40ca-b82d-7c6fb219878a@default> (Drew Adams's message of "Fri, 29 Apr 2016 09:11:31 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> > If we make this change, then autoloads that want to have a single space
> > at the start of the string (and use this syntax to do that) would then
> > not have that space?
>
> No. See the bug report. Only the first SPC should be used
> as a separator. If you want an initial SPC char included
> then you use SPC SPC.
>
> > Have you examined the sources to see whether that's potentially a
> > problem?
>
> No. Do you see a problem with it? Do you disagree that this
> is a bug, regardless of whether you doubt the proposed solution?
The emacs-25 version of `autoload-generate-file-autoloads' does not
contain a call to `char-after', so I think it has been rewritten in the
meantime.
Moreover, if I let Emacs generate file autoloads for a file with this
content:
#+begin_src emacs-lisp
;;;###autoload (autoload 'icicle-mode "icicles"
;;;###autoload"Icicle mode: Toggle minibuffer input completion and cycling.
;;;###autoloadNon-nil prefix ARG turns mode on if ARG > 0, else off.
;;;###autoloadIt is a global minor mode. It binds minibuffer keys."
;;;###autoloadt nil)
#+end_src
(update-file-autoloads
"/home/micha/today/test.el"
nil
"/home/micha/today/test-auto.el")
the result looks like this:
#+begin_src emacs-lisp
(autoload 'icicle-mode "icicles"
"Icicle mode: Toggle minibuffer input completion and cycling.
Non-nil prefix ARG turns mode on if ARG > 0, else off.
It is a global minor mode. It binds minibuffer keys."
nil)
#+end_src
So this generates a sane docstring.
Is this acceptable?
Michael.
next prev parent reply other threads:[~2016-05-01 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 0:03 bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Drew Adams
2016-04-28 22:29 ` Lars Ingebrigtsen
2016-04-29 16:11 ` Drew Adams
2016-05-01 15:34 ` Michael Heerdegen [this message]
2016-05-01 16:11 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg9l3i8e.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=13670@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.