From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Lee Bochicchio <lboc.home@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 3a21ea1: Add more abbrev tests
Date: Tue, 03 May 2016 19:22:01 +0200 [thread overview]
Message-ID: <87eg9j3vly.fsf@gnus.org> (raw)
In-Reply-To: <jwvk2jbjd7c.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Tue, 03 May 2016 12:54:40 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> + (let* ((table (obarray-make)))
>> + (abbrev-table-put table :abbrev-table-modiff 42)
>> + (should (abbrev-table-empty-p table))))
>
> AFAIK this is a detail of the implementation, so I'm not sure we want to
> test it.
> I'd rather test
>
> (should (abbrev-table-empty-p (make-abbrev-table)))
Ok; fixed now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2016-05-03 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160502221340.17892.39911@vcs.savannah.gnu.org>
[not found] ` <E1axM60-0004fY-Fp@vcs.savannah.gnu.org>
2016-05-03 16:54 ` [Emacs-diffs] master 3a21ea1: Add more abbrev tests Stefan Monnier
2016-05-03 17:22 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg9j3vly.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=lboc.home@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.