From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Agenda filter by any tag seems to be broken
Date: Thu, 19 May 2016 10:38:20 +0200 [thread overview]
Message-ID: <87eg8ywigz.fsf@saiph.selenimh> (raw)
In-Reply-To: <87wpms3uu2.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 18 May 2016 11:31:49 +0800")
Hello,
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Okay, there's the problem. In the org git repo, the code above has been
> that way since it was added in 2015. In the package-manager version,
> however, it now looks like this:
>
> (let* ((tag (substring x 1))
> (isregexp (and (equal "{" (substring tag 0 1))
> (equal "}" (substring tag -1))))
> regexp)
>
> And the `substring' calls raise the error. The code is the same in the
> "org" and "org-plus-contrib" packages.
>
> I don't know where the different code comes from, or who maintains it,
> or why it's different from the org git repo, but it would be nice if
> someone could look into fixing that!
Fixed. Thank you for the detailed report.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-05-19 8:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 3:30 Agenda filter by any tag seems to be broken Eric Abrahamsen
2016-05-16 18:28 ` Kaushal Modi
2016-05-17 0:37 ` Eric Abrahamsen
2016-05-17 19:40 ` Kaushal Modi
2016-05-18 3:31 ` Eric Abrahamsen
2016-05-19 8:38 ` Nicolas Goaziou [this message]
2016-05-19 13:46 ` Eric Abrahamsen
2016-05-17 2:00 ` Eric Abrahamsen
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 3:30 Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg8ywigz.fsf@saiph.selenimh \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.