From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#19627: 25.0.50; eshell: only the first item from eshell-visual-options is honored Date: Sun, 03 Jul 2016 22:47:54 -0400 Message-ID: <87eg7adspx.fsf@users.sourceforge.net> References: <87387757p1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1467600507 24012 80.91.229.3 (4 Jul 2016 02:48:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2016 02:48:27 +0000 (UTC) Cc: 19627@debbugs.gnu.org To: Samer Masterson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 04:48:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJtvi-0000C4-IP for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2016 04:48:14 +0200 Original-Received: from localhost ([::1]:44913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJtvh-0000MA-QU for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 22:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJtvb-0000LO-K2 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 22:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJtvW-0006RX-LI for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 22:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJtvW-0006RP-H0 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 22:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJtvV-0000Kv-TB for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 22:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2016 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19627 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19627-submit@debbugs.gnu.org id=B19627.14676004751280 (code B ref 19627); Mon, 04 Jul 2016 02:48:01 +0000 Original-Received: (at 19627) by debbugs.gnu.org; 4 Jul 2016 02:47:55 +0000 Original-Received: from localhost ([127.0.0.1]:36373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJtvP-0000Ka-3O for submit@debbugs.gnu.org; Sun, 03 Jul 2016 22:47:55 -0400 Original-Received: from mail-io0-f174.google.com ([209.85.223.174]:33810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJtvN-0000KD-5u; Sun, 03 Jul 2016 22:47:53 -0400 Original-Received: by mail-io0-f174.google.com with SMTP id g13so141582630ioj.1; Sun, 03 Jul 2016 19:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yFSSAFv7r/pnFpifGV7tDybrwvf0p4kktA7eXLh0igw=; b=jUX7ybOhfjjt4QmhxjJ+EhKzIAZ/R72oG8rz3dOBXly62cfxlMGe9aEc4zIzP9TpJJ PCUiLMNT9g1Zd45plRlW70dqgZEuEatDPSfA8cFLDXrQVsnelKNUc9E7ySOTzPVYGVqL 5znQAsbP4gxY7aWry3Fe5Mq5mUDx/3fwUxY1bLXUuW8R+2s7nzb5orJKnBvwx8GCKoRy hE6VhCpSMUWbvYMw1qaaJ8/wMFMFBibPh1LbwZopfxVCBuQ3/qSeiorFsOwY9876ndfP qH9Smr2O2tduvUCmvf+tbNvQkQd/vj5Pgv3+/lhH+f2pZoPD2TlnJ3dQtwQBO0m35wYh NcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=yFSSAFv7r/pnFpifGV7tDybrwvf0p4kktA7eXLh0igw=; b=btKi/zv4CTFtt25fpy3xnnF9iFVS6xy2VNpIF1nOYnbHoWKXo/wz8ZsgAv6Revtrdm MWoSJ/E+GhSmLOAii/H2i4eHpVr4DB4oPtXRxvRUjOyj20SneQMIS31FiwuYuqcBTBpr ViKsw8bxlM6DAAsRqgDzVG53N9eJwqQ7Kfi/7pc3QGZi9eoBbVdXdudppfT+gQTKDEjr MEDpKonZFLUHNcIuiUWp61wvNItoL41heMUujYRiGUi99cPdWMnF7ycMbq3RzX061ore plmq0k+xTz/Z5FbPrfp0SlsFHBeIsaavVXOIDFDvPi08UVKmp7v41TUOBCZjdds8Td3I 5OeQ== X-Gm-Message-State: ALyK8tJiu6YZNPbpq6zjuzWmViAfJNXajJh7+iRqF4x0JgqoF06n1tO90ntTaxYPLSugUQ== X-Received: by 10.107.30.5 with SMTP id e5mr8761076ioe.129.1467600467668; Sun, 03 Jul 2016 19:47:47 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id q128sm179485iod.30.2016.07.03.19.47.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jul 2016 19:47:47 -0700 (PDT) In-Reply-To: <87387757p1.fsf@gmail.com> (Samer Masterson's message of "Mon, 19 Jan 2015 03:30:18 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120380 Archived-At: --=-=-= Content-Type: text/plain severity 19627 minor quit Samer Masterson writes: > 1. "emacs -Q" > 2. M-x eshell > 3. "git --help" prints the help text to the buffer > 4. (add-to-list 'eshell-visual-options '("git" "--help")) > 5. "git --help" brings up the term display (which is quickly killed, > that is bug#18108) > 6. (add-to-list 'eshell-visual-options '("git" "--help")) I guess you actually meant "--version" rather than "--help" again here. > 7. "git --help" > bug: > "git --help" prints the help text to the buffer. > expected behavior: > "git --help" should have brought up a term-mode buffer, as it's still > part of eshell-visual-options. eshell-visual-options is an alist (as mentioned in the docstring), so the newest "git" entry decides which options are in force. To get what you want, you should do: (add-to-list 'eshell-visual-options '("git" "--help" "--version")) or possibly (push "--version" (cdr (assoc "git" eshell-visual-options))) Maybe the docs can be improved to explain this better. Is it enough to change the example usage to have 2 different options? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Clarify-usage-of-eshell-visual-options.patch Content-Description: patch >From c51bb7b36ef7f0bbe3e69c8fe16abc6b2ca8a6c1 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 3 Jul 2016 22:41:48 -0400 Subject: [PATCH v1] Clarify usage of eshell-visual-options * lisp/eshell/em-term.el (eshell-visual-options): Add second option to example usage. --- lisp/eshell/em-term.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/eshell/em-term.el b/lisp/eshell/em-term.el index 3e5de0c..208629c 100644 --- a/lisp/eshell/em-term.el +++ b/lisp/eshell/em-term.el @@ -102,10 +102,11 @@ eshell-visual-options of commands with options that present their output in a visual fashion. For example, a sensible entry would be - (\"git\" \"--help\") + (\"git\" \"--help\" \"--paginate\") because \"git --help\" shows the command's -documentation with a pager. +documentation with a pager and \"git --paginate \" +always uses a pager for output. See also `eshell-visual-commands' and `eshell-visual-subcommands'." :type '(repeat (cons (string :tag "Command") -- 2.8.0 --=-=-=--