From: Robert Cochran <robert-emacs@cochranmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Philipp Stephani <p.stephani2@gmail.com>,
Robert Cochran <robert-emacs@cochranmail.com>,
23957@debbugs.gnu.org
Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function
Date: Tue, 12 Jul 2016 12:11:53 -0700 [thread overview]
Message-ID: <87eg6yvfgm.fsf@cochranmail.com> (raw)
In-Reply-To: <ec3b876c-1e46-4553-9138-8d8fa972fa4c@default> (Drew Adams's message of "Tue, 12 Jul 2016 17:49:17 +0000 (UTC)")
I didn't put too much thought into reading the FIXME; I figured that
someone smarter than myself knew what they were doing when requesting
the change.
I'd personally argue that anyone making an explicit check for t, or
anything that particularly needs t rather than any true value is just
asking for lossage, but I can see why people would disagree with that
assertion.
FWIW, In every placed I changed occurrences of fboundp to
symbol-function, both in Lisp and C, used only the truthiness of the
return rather than explicitly checking for t.
I also ran the test suite with and without my patch applied, and noticed
no difference in the number of failing tests.
Anyways, I'm willing to toss this patch and do something else if that is
the general consensus.
Thanks,
~Robert Cochran
next prev parent reply other threads:[~2016-07-12 19:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 7:08 bug#23957: [PATCH] Make fboundp an alias for symbol-function Robert Cochran
2016-07-12 16:13 ` Drew Adams
2016-07-12 17:40 ` Philipp Stephani
2016-07-12 17:49 ` Drew Adams
2016-07-12 19:11 ` Robert Cochran [this message]
2016-07-12 20:06 ` Drew Adams
2016-07-12 23:02 ` Robert Cochran
2016-07-13 2:14 ` Drew Adams
2016-07-12 19:20 ` Sora Firestorm
2016-07-12 20:10 ` Drew Adams
2016-07-12 20:35 ` Stefan Monnier
2016-07-13 5:35 ` Robert Cochran
2016-07-14 22:53 ` Robert Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg6yvfgm.fsf@cochranmail.com \
--to=robert-emacs@cochranmail.com \
--cc=23957@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.