From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Date: Tue, 19 Jul 2016 10:50:07 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87eg6pr8bk.fsf@lifelogs.com> References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> <87r3aqcz7y.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468939893 26549 80.91.229.3 (19 Jul 2016 14:51:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 14:51:33 +0000 (UTC) Cc: 23945@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 16:51:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPWMi-0007Cn-Jm for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 16:51:20 +0200 Original-Received: from localhost ([::1]:56537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPWMi-0007xj-36 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 10:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPWMW-0007ud-JF for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 10:51:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPWMR-0006dl-D8 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 10:51:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPWMQ-0006d8-AD for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 10:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPWMQ-0000v1-1u for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2016 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23945-submit@debbugs.gnu.org id=B23945.14689398223471 (code B ref 23945); Tue, 19 Jul 2016 14:51:01 +0000 Original-Received: (at 23945) by debbugs.gnu.org; 19 Jul 2016 14:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:57430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPWLm-0000tv-78 for submit@debbugs.gnu.org; Tue, 19 Jul 2016 10:50:22 -0400 Original-Received: from mail-pf0-f182.google.com ([209.85.192.182]:33782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPWLj-0000th-Hq for 23945@debbugs.gnu.org; Tue, 19 Jul 2016 10:50:20 -0400 Original-Received: by mail-pf0-f182.google.com with SMTP id y134so8119828pfg.0 for <23945@debbugs.gnu.org>; Tue, 19 Jul 2016 07:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=DwnUuls0eaRoFuhetWJOc0C41fiCm4nsfLMwiafpls4=; b=OuJhJrkOS6vK4rqabZFeywvUnEBNdYICnUDxSSj+rtfDx8uO1GQxh6sQH0kaIsSV4Q e2w8V94xpK+8yrImVG2JtJYMacS+hj9pqu8eRq5ItD473bGat6OSXNlMt5tRqHekwswb fmINp2LPTXrZTSmtl5WOBz8xJb2lABcy3v828= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=DwnUuls0eaRoFuhetWJOc0C41fiCm4nsfLMwiafpls4=; b=DFK6pOgGvOoqzL2dMbKpgrpzpf59YxfgiZI8H636MJOKWx2E0C8MfHZZvO+AYlWsjW pqFNJkFHMFcxwyN9KgjG4Zc33EfXKDO8krhZ621d/U6OsEm5+iVLf9RbYfg9LucFj7BU /OKqUq3yNpmA+GDzsW2yuYBSnPIfJRC1YG42sdv/jTmvTwK+UDpbLH59xWdOd3/JswUN YqiL8SPwJ59TPFklI/dzy0wdI8tO1ag5OUnTELKUHfjUbUf1IjgxbNhfgREJERBpdd3z doSO2glmxq6jaqIbQFDGhgWsc6O8hlxwMuXr2V2K6GYTEC6LTKvW39ATdloWecCQWVk4 o9gg== X-Gm-Message-State: ALyK8tIAsvriTgj0dH2riXoTr5rBcw58UQE6woOi7FKRfeYL9zhKywDnSGhjmhFVZo3jUw== X-Received: by 10.98.101.198 with SMTP id z189mr55746365pfb.53.1468939813666; Tue, 19 Jul 2016 07:50:13 -0700 (PDT) Original-Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id lf11sm5347560pab.17.2016.07.19.07.50.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 07:50:12 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87r3aqcz7y.fsf@users.sourceforge.net> (npostavs's message of "Mon, 18 Jul 2016 19:18:09 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121259 Archived-At: On Mon, 18 Jul 2016 19:18:09 -0400 npostavs@users.sourceforge.net wrote: >> I converted `gnus-cloud-method' to a defcustom and added the necessary >> code to set it, resolving this question. >> >> Since no one has been interested in reviewing this code, I will merge it >> tomorrow. n> Perhaps this is partly because I'm not familiar with the code (or what n> "Gnus Cloud" is), but it seems to me that you're missing a good summary n> line explaining what any of these changes are for. The bug title and n> commit message summary line mentions only "Gnus Cloud work". What n> "work"? This feels actively reviewer-hostile. You're right. The history of this work goes back at least 4 years in the Gnus mailing list so I was hoping Lars or someone else familiar with that history would jump in. You can start with the most recent log of work I did: http://thread.gmane.org/gmane.emacs.gnus.general/85543/focus=87091 I will write docs for the feature, but simply wasn't sure about some key aspects of it that depended on the code. Please note I did add docstrings for most of the functions, especially the interactive ones. But I agree that's no excuse for a lack of good commit messages. n> The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better n> (at least we can tell it's about UI), though adding 20 or so "Merge n> branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't n> help much either. Well, that's an issue with the source code repo. I've mentioned it before. Here's my rant: I merge the master branch often because I have been using the gnus-cloud branch and want to make sure it's not broken against master. I also test and use many other new features. I really don't want to start working outside the master branch. But I can't rebase and push again, because the repo doesn't support non-fast-forward pushes. I have to delete and recreate the branch (notification emails x2, and a little bit of manual labor). But also every time I do a push with merges, notification e-mails come out for my changes plus everything merged. I can't win either way. So the bottom line for me is, I'd really like notification e-mails not to go out for "scratch/*" branches, or to be able to do a non-fast-forward push to my scratch branch. Since neither is possible, I'm doing the best I can for now. I am strongly considering using Github next time (Git supports multiple remotes for a branch, so this is not too hard) and saving myself all this trouble. You can use `git log --no-merges' meanwhile to filter out those merge commits. Sorry for the inconvenience. Ted