From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kalle Olavi Niemitalo Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix macOS 12 deprecation notices Date: Sun, 21 Aug 2016 09:59:23 +0300 Message-ID: <87eg5ivc8k.fsf@Niukka.kon.iki.fi> References: <315BE3C4-D984-470E-A4B4-20C8148FBA5A@play-bow.org> <20160818190422.GA23177@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1471762777 15729 195.159.176.226 (21 Aug 2016 06:59:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Aug 2016 06:59:37 +0000 (UTC) User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.51 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 21 08:59:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbMjF-0003uW-0N for ged-emacs-devel@m.gmane.org; Sun, 21 Aug 2016 08:59:33 +0200 Original-Received: from localhost ([::1]:35608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbMjE-0005Re-B6 for ged-emacs-devel@m.gmane.org; Sun, 21 Aug 2016 02:59:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbMj8-0005RT-6d for emacs-devel@gnu.org; Sun, 21 Aug 2016 02:59:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbMj5-000526-4N for emacs-devel@gnu.org; Sun, 21 Aug 2016 02:59:26 -0400 Original-Received: from sirokuusama2.dnainternet.net ([83.102.40.153]:36768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbMj4-00051f-Ts for emacs-devel@gnu.org; Sun, 21 Aug 2016 02:59:23 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by sirokuusama2.dnainternet.net (Postfix) with ESMTP id 5EAEC1CEF; Sun, 21 Aug 2016 09:59:14 +0300 (EEST) X-Virus-Scanned: DNA Internet at dnainternet.net Original-Received: from sirokuusama2.dnainternet.net ([83.102.40.153]) by localhost (sirokuusama2.dnainternet.net [127.0.0.1]) (DNA Internet, port 10040) with ESMTP id TY7m9U1OK5N6; Sun, 21 Aug 2016 09:59:14 +0300 (EEST) Original-Received: from omenapuu2.dnainternet.net (omenapuu2.dnainternet.net [83.102.40.54]) by sirokuusama2.dnainternet.net (Postfix) with ESMTP id 1EE8C1D46; Sun, 21 Aug 2016 09:59:14 +0300 (EEST) Original-Received: from Niukka.Niemitalo.private (87-95-90-33.bb.dnainternet.fi [87.95.90.33]) by omenapuu2.dnainternet.net (Postfix) with ESMTP id C380D294; Sun, 21 Aug 2016 09:59:11 +0300 (EEST) In-Reply-To: <20160818190422.GA23177@breton.holly.idiocy.org> (Alan Third's message of "Thu, 18 Aug 2016 20:04:22 +0100") X-Accept-Language: fi;q=1.0, en;q=0.9, sv;q=0.5, de;q=0.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 83.102.40.153 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206717 Archived-At: Alan Third writes: > * src/nsterm.h: Add #defines to allow older versions of macOS to use the > new constant names. > * src/nsmenu.m: Replace old constant names with new. > * src/nsterm.m: Replace old constant names with new. > * src/nsfns.m: Replace old constant names with new. Your patch also removes two setMenuChangedMessagesEnabled calls from src/nsmenu.m. That seems unrelated to constant names.