From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: Add org-bookmark-heading to Org proper?
Date: Sat, 24 Sep 2016 20:40:26 -0500 [thread overview]
Message-ID: <87eg48vjsl.fsf@alphapapa.net> (raw)
In-Reply-To: 87k2e2i6m9.fsf@nicolasgoaziou.fr
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
Hi Nicolas,
> I think controlling how the bookmark locations are displayed is
> a different feature, which may fit better in Bookmark than in Org.
I think I see what you mean, but at the same time, it seems like an
Org-specific feature since it calls org-tree-to-indirect-buffer. I
guess I think of Org as building on core Emacs features, so putting an
Org-specific feature in core bookmark.el seems...backwards? (Though I'm
not sure that's what you meant...)
> We could introduce a generic hook somewhere so that to permit users
> adding their own display mechanism. However, the variable is, IMO, too
> specific.
That hook idea sounds interesting, but I'm not sure I understand how it
would be different than the built-in bookmark-handler feature.
bookmark-handle-bookmark says that the handler it calls, "changes
current buffer and point and returns nil, or signals a `file-error'," so
that's what my org-bookmark-jump handler does, in an Org-specific way.
The indirect-buffer feature could of course be removed from
org-bookmark-jump, and a user could add it himself as advice that runs
afterward.
Or maybe something like an org-bookmark-jump-hook could be added to call
other functions after jumping to an Org bookmark. I guess this is what
you meant, I just had to talk myself through it. :)
> On another topic, by looking at bookmark.el, it seems you shouldn't
> create the internal representation of the bookmarks by hand, and use
> setters instead (e.g., `bookmark-set-filename').
I went by the docstring for bookmark-make-record-function, which says
that modes can set it buffer-locally for locations that should be
treated specially, and that the function called should return a record
according to bookmark-alist. I guess the setters are intended for
modifying existing bookmarks...?
Thanks for your feedback.
next prev parent reply other threads:[~2016-09-25 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:33 Add org-bookmark-heading to Org proper? Adam Porter
2016-09-22 15:11 ` Xebar Saram
2016-09-22 15:19 ` Kaushal Modi
2016-09-22 17:04 ` Adam Porter
2016-09-22 15:52 ` Aaron Ecay
2016-09-22 17:01 ` Adam Porter
2016-09-22 19:35 ` Nicolas Goaziou
2016-09-22 23:40 ` Adam Porter
2016-09-24 17:11 ` Nicolas Goaziou
2016-09-25 1:40 ` Adam Porter [this message]
2016-09-25 8:14 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg48vjsl.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.