From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Tue, 13 Dec 2016 23:04:45 -0500 Message-ID: <87eg1bcg0y.fsf@users.sourceforge.net> References: <7cb86247-1e30-f029-0b9b-c53cc096ec4b@easy-emacs.de> <87mvggh2hu.fsf@users.sourceforge.net> <87h967cj0f.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1481688261 1126 195.159.176.226 (14 Dec 2016 04:04:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Dec 2016 04:04:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24870@debbugs.gnu.org, Alan Mackenzie , Matt Armstrong To: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 14 05:04:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH0nd-0007JV-Na for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2016 05:04:13 +0100 Original-Received: from localhost ([::1]:45392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH0ni-0003qc-30 for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2016 23:04:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH0nV-0003by-NH for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 23:04:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cH0nS-0006Ku-JE for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 23:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54126) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cH0nS-0006Kp-FS for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 23:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cH0nS-00030k-1S for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 23:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2016 04:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.148168823111553 (code B ref 24870); Wed, 14 Dec 2016 04:04:01 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 14 Dec 2016 04:03:51 +0000 Original-Received: from localhost ([127.0.0.1]:41292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH0nH-00030H-6y for submit@debbugs.gnu.org; Tue, 13 Dec 2016 23:03:51 -0500 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:35918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH0nF-000305-EN for 24870@debbugs.gnu.org; Tue, 13 Dec 2016 23:03:49 -0500 Original-Received: by mail-io0-f181.google.com with SMTP id 136so20246787iou.3 for <24870@debbugs.gnu.org>; Tue, 13 Dec 2016 20:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=I0a8evumFCjNqV9kCjvR7snUwF7FDlLT5auOKzSxQdM=; b=Odo9LjlY2Fz7ByQMHq9WqLfNtrICGEO0Oaj+2MvmA72ZKD+sjVj6W3C2e/nHLTV9Id T5IIELA4TzynQEsc46b7cHgrfuKw57rPYu19XoeRhezPjaXkNPVL2sN9BJV+unojjiWV /1f/18ZYMhiFoe0TruYiG+MhXG6J+cWfrP9+NS6vMsWdDnxD+abd4tILZr8PVVjw1oFR 3Pqx18xiDntLhvX43M4BTDYMwQqNcphQ21yqZzCPY9ZFgAU5wyGnqWXmjtvSrthfgpX5 Hgoo/eA7klepemFM5NITHC5pbrbUdmP0eSvaFbs9/a264zQISPeqca+xEZJsFwsaphvh t0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=I0a8evumFCjNqV9kCjvR7snUwF7FDlLT5auOKzSxQdM=; b=AC5G1m8GKGZXlJjNXYNDGpuDWh/97mJL5C+PJAcpf+0+WdNvKq2T1XdOrH2pDRxN/a PeaPTF1mimZVDmn1CJ+NFU6qoZcJZ6+RsnJ/W305rZlnHt0+NvgJ1XcV5RaD7EsDugrZ YnVq5+wmC6BqG6A46XXXUJu4BX0qJ7lGKI+0DBBUqqj+N1PvHrHHRmciGrESrq/bFacn N26w2MMx91ZtebfqDACeC76jkbM6eQ11xH0qmUivGtGSDfyN8MS12ZK0NhclD+1aKVu3 k3BC2RNAqb8nYiCc0flPqZvCxcZTNWenh88a92FfEswxsPGAjrS5DquX/dFyo2iVBCJu JNhA== X-Gm-Message-State: AKaTC0098X2hJW1SMGwWpTJ5pIGhVHe08aJw2CuOxhh5qnl1Zpb7IFTYhSahj3O+MPk3cA== X-Received: by 10.36.224.200 with SMTP id c191mr5590649ith.118.1481688223882; Tue, 13 Dec 2016 20:03:43 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id q82sm1971806itd.10.2016.12.13.20.03.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Dec 2016 20:03:43 -0800 (PST) In-Reply-To: <87h967cj0f.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Tue, 13 Dec 2016 22:00:16 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127024 Archived-At: --=-=-= Content-Type: text/plain npostavs@users.sourceforge.net writes: > > > I have tracked the issue down to scan_sexps_forward in syntax.c Applying this change which reverts part of [1] seems to fix the issue: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=bug-24870-quick-fix.diff Content-Description: diff that seems to fix this bug --- i/src/syntax.c +++ w/src/syntax.c @@ -3192,7 +3192,11 @@ scan_sexps_forward (struct lisp_parse_state *state, while (from < end) { - if (SYNTAX_FLAGS_COMSTART_FIRST (prev_from_syntax) + INC_FROM; + code = prev_from_syntax & 0xff; + + if (from < end + && SYNTAX_FLAGS_COMSTART_FIRST (prev_from_syntax) && (c1 = FETCH_CHAR (from_byte), syntax = SYNTAX_WITH_FLAGS (c1), SYNTAX_FLAGS_COMSTART_SECOND (syntax))) @@ -3213,8 +3217,6 @@ scan_sexps_forward (struct lisp_parse_state *state, } else { - INC_FROM; - code = prev_from_syntax & 0xff; if (code == Scomment_fence) { /* Record the comment style we have entered so that only --=-=-= Content-Type: text/plain Alan, can you explain what the idea behind that change was? I think it might correspond to this part of the commit message: Reformulate code at the top of the main loop correctly to recognize comment openers when starting in the middle of one. [1]: 9dcf5998935c Sun Mar 20 13:19:48 2016 +0000 "Amend parse-partial-sexp correctly to handle two character comment delimiters" --=-=-=--