From: npostavs@users.sourceforge.net
To: Mark Karpov <markkarpov@openmailbox.org>
Cc: 25157@debbugs.gnu.org, Reuben Thomas <rrt@sc3d.org>
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Mon, 19 Dec 2016 23:36:15 -0500 [thread overview]
Message-ID: <87eg13b4jk.fsf@users.sourceforge.net> (raw)
In-Reply-To: <8760mr26dr.fsf@openmailbox.org> (Mark Karpov's message of "Sat, 10 Dec 2016 17:41:52 +0300")
tags 25157 confirmed
quit
Mark Karpov <markkarpov@openmailbox.org> writes:
> The ‘whitespace-cleanup’ command does not remove single trailing empty
> line anymore.
This seems to have been caused by the fix for #24745.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24745#5 has
-(defcustom whitespace-empty-at-eob-regexp "^\\([ \t\n]+\\)"
+(defcustom whitespace-empty-at-eob-regexp "^\\([ \t\n]+\\)\\'"
which is what I would expect, but
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24745#11 says
First, I revised my previous patch, which had an error in the new
version of whitespace-empty-at-eob-regexp.
and has
-(defcustom whitespace-empty-at-eob-regexp "^\\([ \t\n]+\\)"
+(defcustom whitespace-empty-at-eob-regexp "^\\([ \t\n]*\\(\n\\{2,\\}\\|[ \t]+\\)\\)\\'"
I don't quite understand why this more complicated expression is
necessary. Reuben, can you explain?
next prev parent reply other threads:[~2016-12-20 4:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 14:41 bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Mark Karpov
2016-12-20 4:36 ` npostavs [this message]
2016-12-20 18:37 ` Reuben Thomas
2016-12-21 0:51 ` Reuben Thomas
2016-12-21 4:07 ` npostavs
2016-12-21 11:07 ` Reuben Thomas
2016-12-22 2:18 ` npostavs
2016-12-22 12:53 ` Reuben Thomas
2016-12-23 0:03 ` npostavs
2016-12-23 10:44 ` Reuben Thomas
2016-12-24 15:34 ` npostavs
2016-12-26 22:37 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg13b4jk.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25157@debbugs.gnu.org \
--cc=markkarpov@openmailbox.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.