From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patch for Emacs 25.2 Date: Mon, 16 Jan 2017 22:49:38 +0100 Message-ID: <87eg024qvh.fsf@gmx.de> References: <87o9z7s5iq.fsf@gmx.de> <83eg039e93.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484603677 28193 195.159.176.226 (16 Jan 2017 21:54:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Jan 2017 21:54:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 16 22:54:33 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTFEO-0006Gn-87 for ged-emacs-devel@m.gmane.org; Mon, 16 Jan 2017 22:54:24 +0100 Original-Received: from localhost ([::1]:59880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTFET-0004rr-1g for ged-emacs-devel@m.gmane.org; Mon, 16 Jan 2017 16:54:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTF9u-0002fo-4B for emacs-devel@gnu.org; Mon, 16 Jan 2017 16:49:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTF9q-00055f-58 for emacs-devel@gnu.org; Mon, 16 Jan 2017 16:49:46 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:63332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTF9p-00055b-Rx; Mon, 16 Jan 2017 16:49:42 -0500 Original-Received: from detlef.gmx.de ([93.197.214.201]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MNYxW-1cNALe1cy2-007AIm; Mon, 16 Jan 2017 22:49:40 +0100 In-Reply-To: <83eg039e93.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Jan 2017 18:11:04 +0200") X-Provags-ID: V03:K0:+z2567nPKBysx0ckO8bDRcAhrC2QohYuInTDlR45frMxgvSxnNO P/WvJ1sUGw1+ByLCmwqvDGQIy7uaaohmfMyQwpLNaOWj2HK8eD9lwwIvrTNaQLi43HtW6LE +sOKb/U2kBbQ10b622u8IK/LtDGqELpASTiSAmngbcW51RRig2i1oqJ8QtxSL5bCMLX3Akr bJKySQ4xYmBKIMV2E2Y6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:WtzdPKr4OSY=:tcr5a4TMNZsW8g+ptt+qR+ 27FvfHX9cA1HebxCjMRmnPWzJeHBjxuOGqr3h2V9EvdxMUP5BgMMGB0pRT+XM2nUYQ8jA/m/e 5wuKkWX7F7J8+LtsN91nPT6dCRMFR2/NkgxVi4VXUc3IR1GoeWMVsN5JYnzSmJpRaNqQP+dDu gFdWMAVmshJp8SR/7KRx718/twkf1yJzbobuzMNqE3c7t8ZFtVGRv2G8kTLxd+ABNUOFQZRcb +0wtDuNrcyBwDYa+JSdLD/mK/rxgFJenQnhJoAoWvAjn/xo4JZrxM8rT2hSjr9/13eobe5ni7 pU6XO8F1W5XdD2kATKmrld5vgzgqXxFeC4h75zNZrkcT7M9W6oVIBTWlBFd0WvX6tmhynBQ7Q JOAxjjEvxpCa1onv0mw4Zw8dzaVqTaWuQhpODur/R7eR58+4LJP43jwhXMOzrbIJ8kETZBZjo xpUsELtryHWwRPF5XrIiohztva44EHc585ZMNhxd9WDnG3UHEwZWPhy2OhzPYDbmCu3MvT4mx Mh5Jn5qUg0BMGQLmYmF9kDDFmu4J3ftffrMgvI1Y6AGldsbV/Zb2vwFPjPnHdxU32U61uHdKY 9dnh52TiE/0wLrvy24C1EDL1WBp3j+4txLcUi9lW86B2X0kQn7zg3Bsat5cXkEWkLebcv4J8R YsrLs1ZX82H+sjTykl39agwg3D+pQ3zU8fCCb3kPtha2DhT4jBltjtmoviDvkt9RvhHrjfA1h HbwNAuYYHtcMwqG4H0AY+/TytS6TgiJUM4n/Es9YfeORt4wKyAFzkKdg815ijKhOJ85A8BnJ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211338 Archived-At: Eli Zaretskii writes: Hi Eli, > Do I understand correctly that fixing the bug introduced by e3a0f3d > requires only the change in tramp.el? That's correct. > Regarding the other bug and its fix in files.el, can you tell more > about the bug? A change in files.el affects a very broad class of use > cases, so I'd like to know more before I make up my mind about it. In `make-auto-save-file-name', there is twice a test for ang-ftp file names: --8<---------------cut here---------------start------------->8--- (not (string-match "^/\\w+@[-A-Za-z0-9._]+:" result))) --8<---------------cut here---------------end--------------->8--- The regexp matches ange-ftp file names like "/user@host:". It does not match general Tramp syntax, like "/method:user@host:" or "/host:". As result, on MS Windows there is an error like --8<---------------cut here---------------start------------->8--- (let ((buffer-file-name "/method:user@host:/path/to/file") tramp-auto-save-directory auto-save-file-name-transforms) (make-auto-save-file-name)) => "\\method!user@host!\\path\\to\\#file#" --8<---------------cut here---------------end--------------->8--- The patch replaces this regexp by --8<---------------cut here---------------start------------->8--- (not (file-remote-p result))) --8<---------------cut here---------------end--------------->8--- Then it works as expected: --8<---------------cut here---------------start------------->8--- (let ((buffer-file-name "/method:user@host:/path/to/file") tramp-auto-save-directory auto-save-file-name-transforms) (make-auto-save-file-name)) => "/method:user@host:/path/to/#file#" --8<---------------cut here---------------end--------------->8--- The patch is harmless enough that I propose it for Emacs 25.2. > Thanks. Best regards, Michael.