From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#7485: 23.2; Fix removing unrecognized ANSI sequences in ansi-color-apply Date: Mon, 03 Jul 2017 21:48:16 -0400 Message-ID: <87eftxht0f.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499132837 26787 195.159.176.226 (4 Jul 2017 01:47:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 01:47:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 7485@debbugs.gnu.org, Stefan Monnier To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 04 03:47:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSCvm-0006YA-Da for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Jul 2017 03:47:10 +0200 Original-Received: from localhost ([::1]:38267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSCvq-0003jL-DU for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jul 2017 21:47:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSCvh-0003ht-DJ for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2017 21:47:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSCve-00069q-94 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2017 21:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSCve-00069M-58 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2017 21:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dSCvd-0005xH-Sd for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2017 21:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2017 01:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7485 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7485-submit@debbugs.gnu.org id=B7485.149913281022868 (code B ref 7485); Tue, 04 Jul 2017 01:47:01 +0000 Original-Received: (at 7485) by debbugs.gnu.org; 4 Jul 2017 01:46:50 +0000 Original-Received: from localhost ([127.0.0.1]:51010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSCvR-0005wg-OE for submit@debbugs.gnu.org; Mon, 03 Jul 2017 21:46:49 -0400 Original-Received: from mail-io0-f194.google.com ([209.85.223.194]:35785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSCvO-0005wM-PT; Mon, 03 Jul 2017 21:46:47 -0400 Original-Received: by mail-io0-f194.google.com with SMTP id 84so10172585iop.2; Mon, 03 Jul 2017 18:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zXoYnH2vhxj0Xuz4PTgNOGN57osG+qAXArtf9gQlj20=; b=VeyvLDvtSGGt8Fu8BBONtJThT+rGBk2PYWhgek3C5jvpoqd3hU1DkbdlQQWFFvMcdy wko6bfIWDzDd4oYHH+rAizGH0oCwHVX4yG39lugEDVD/i3TgG3DfAD9aU/C2oDEdIBgB snw3OwSU+gFkxe3y64eLWPkWmVWzmSefkObKjZVE7Q4mDnlLU40r/mohqiZkdpmXLuP/ 3uYa2qtGLgoohwYbMymRHXF2z2tahMMaX5BpBi53eUXEEkDSnUEQeveJ37DmOYq9Zedu gIwb3KNTHlKn5uGSk2TpBQnpAVMHsxx2tWlZvrFl+VYCxWnTQuzuEsnIa6TGatgwyNBV diUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=zXoYnH2vhxj0Xuz4PTgNOGN57osG+qAXArtf9gQlj20=; b=uElOCZ8FvNYojChbq8ja+MpSA/hQoTILNZgdsc+RTmMMDMdbHPnfnAgBnZEItCb6OW 9rhQA9FgAQnEzPXthNv1yNk3y3z2LjyEIoH6Ji2xmu+zIZuO3/VGV47yUrbgOOXS7OMZ WbnWlF19l45ZbNSuujQyw6WtOKSR60AOrMoBqX2OC+DtNL3LPBBA0U57gagYdv3cpQe+ sfWmaTOoRDDu0muUi5qoy0HFqpMXIWUODK3yvvvI+NHheTai26R8Iq5vECK+tHF9Fkmm YlaCkw8GMjr5JrrSxJff2iDt7AEMlBHm7PUgYtOxjTStjmIjbCajKB2N271hEOfcLYo7 5Eeg== X-Gm-Message-State: AKS2vOycjAV1uVDZS2gF+NyHBxIth5fEXhmcbgM/FuzytPmKmBv2prxO zNDzhrnJMkrt+nDF X-Received: by 10.107.169.29 with SMTP id s29mr40294213ioe.61.1499132800721; Mon, 03 Jul 2017 18:46:40 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e34sm9418641ioj.62.2017.07.03.18.46.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 18:46:40 -0700 (PDT) In-Reply-To: (Leo's message of "Fri, 26 Nov 2010 22:41:31 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134153 Archived-At: close 7485 quit Leo writes: > Unrecognized control sequences also begin with char \033. The FRAGMENT > part of ansi-color-context wasn't supposed to contain actual text, > otherwise they might get lost. It should always be a fragment of a whole > ansi control sequence if non-nil. > > Let me show how this stops eshell prompt from showing. > > Assume ansi-color-apply is in eshell-preoutput-filter-functions. Suppose > the output of shell command 'ack linux' ends with an unrecognized > control sequence ^[[K. The whole output string that goes through > ansi-color-apply is > > output of 'ack linux' + 'eshell prompt'. > > After 'ack linux' finishes, the FRAGMENT of ansi-color-context becomes: > > #("^[[K\n~/.emacs.d $ " 4 17 > (read-only t face eshell-prompt rear-nonsticky > (face read-only))) > > The string after being processed by ansi-color-apply is thus without an > eshell prompt. I think this patch is no longer applicable now that I've pushed [1:35ed01dfb3], ansi-color-apply now skips over every escape sequence, not just color escape sequences. Although I'm unable to produce the problem of missing prompts even before my patch (e.g., in 25.2): ~/src $ printf 'ack linux\e[K\n' ack linux ~/src $ [1: 35ed01dfb3]: 2017-07-03 10:09:40 -0400 Fix and simplify ansi escape detection (Bug#21381) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=35ed01dfb3f811a997e26d843e9971eb6b81b125