bug#24402: should-error doesn't catch all errors

[Gemini Lasswell <gazally@runbox.com>]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hello,

First, thank you for working on this bug!

I have a branch of Emacs which attempts to run all the tests under
Testcover, and I've tried it with Alex's latest patch. The patch has
fixed the problems with Testcover and should-error except for one weird
case. Here is a file that will let you reproduce the weird case on
master with the patch applied:


[-- Attachment #2: cyc-test.el --]
[-- Type: text/plain, Size: 449 bytes --]

(defun cyc1 (a)
  (let ((ls (make-list 10 a)))
    (nconc ls ls)
    ls))

(ert-deftest test-cycle-assq ()
  (let ((c1 (cyc1 '(1))))
    (should-error (assq 3 c1) :type 'circular-list)))

(ert-deftest test-cycle-assoc ()
  (let ((c1 (cyc1 '(1))))
    (should-error (assoc 2 c1) :type 'circular-list)))

(defvar testcover-started nil)
(unless testcover-started
  (setq testcover-started t)
  (testcover-start (or load-file-name (buffer-file-name))))

[-- Attachment #3: Type: text/plain, Size: 414 bytes --]


This is an excerpt of test/src/fns-tests.el with a few lines added at
the end to invoke Testcover. It contains two nearly identical tests
which should both pass, but one passes and one fails. If you then edit
the file and comment out test-cycle-assoc (the one that passes) and run
the test again, then the failing test will pass. I've reproduced it both
in batch mode (without TEST_LOAD_EL=no) and interactively.