From: npostavs@users.sourceforge.net
To: Gemini Lasswell <gazally@runbox.com>
Cc: 24402@debbugs.gnu.org, Alex <agrambot@gmail.com>,
Tino Calancha <tino.calancha@gmail.com>
Subject: bug#24402: should-error doesn't catch all errors
Date: Mon, 07 Aug 2017 21:15:14 -0400 [thread overview]
Message-ID: <87efsm507x.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87bmoehpzm.fsf@runbox.com> (Gemini Lasswell's message of "Thu, 20 Jul 2017 12:23:25 -0700")
tags 24402 fixed
close 24402 26.1
quit
Sorry for the delay, I was moving apartment, and then I got a bit
distracted by my 'grep --null' mess.
Gemini Lasswell <gazally@runbox.com> writes:
> npostavs@users.sourceforge.net writes:
>
>> The following appears to fix it, though perhaps we should use a smarter
>> equal function that would consider the circular lists to actually be
>> equal instead of bailing out and returning nil on circularity.
>
> Thanks for tracking this one down and making a patch, which looks good
> to me. Does that smarter equal function already exist? It doesn't seem
> worth the effort of writing one for this purpose only.
Yeah, I left it as is with a TODO. We can fix it later if it turns out
to cause an actual problem.
> Here is a test to add to your patch, which fails without it and passes
> with it:
Thanks, I pushed it to master along with the others.
[1: 054c198c12]: 2017-08-07 18:43:54 -0400
Catch argument and macroexpansion errors in ert
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=054c198c120c1f01a8ff753892d52710b740acc6
[2: 95a04fd26c]: 2017-08-07 18:43:55 -0400
; Avoid test failures when running from compiled test files
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=95a04fd26c91e6c6c9191a629d26886f136e30fc
[3: 0508045ed7]: 2017-08-07 18:54:44 -0400
Don't error on circular values in testcover
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0508045ed7159bce5b5ea3b5fb72cf78b8b4ee8e
[4: 00f7e31110]: 2017-08-07 18:54:48 -0400
Add a test of handling of circular values to testcover-tests
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=00f7e31110a27e568529192d7441d9631b9096bc
prev parent reply other threads:[~2017-08-08 1:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 1:26 bug#24402: 25.1.50; testcover-start breaks should-error Gemini Lasswell
[not found] ` <handler.24402.B.14734739098199.ack@debbugs.gnu.org>
2016-09-20 4:27 ` bug#24402: More Information Gemini Lasswell
2017-07-04 3:28 ` bug#24402: should-error doesn't catch all errors (Was:bug#24402: More Information) Alex
2017-07-05 0:00 ` bug#24402: should-error doesn't catch all errors Alex
2017-07-05 13:43 ` Tino Calancha
2017-07-05 19:56 ` Alex
2017-07-07 10:15 ` Tino Calancha
2017-07-09 7:04 ` Alex
2017-07-11 12:18 ` npostavs
2017-07-12 3:47 ` Alex
2017-07-12 12:30 ` npostavs
2017-07-12 16:45 ` Alex
2017-07-13 1:31 ` npostavs
2017-07-13 3:04 ` Alex
2017-07-13 3:44 ` npostavs
2017-07-13 22:45 ` Alex
2017-07-13 23:49 ` npostavs
2017-07-14 4:42 ` Alex
2017-07-14 4:45 ` Alex
2017-07-15 21:57 ` npostavs
2017-07-16 3:49 ` Alex
2017-07-17 0:46 ` npostavs
2017-07-19 21:23 ` Gemini Lasswell
2017-07-19 22:40 ` Alex
2017-07-19 23:04 ` npostavs
2017-07-20 4:04 ` Alex
2017-07-20 19:23 ` Gemini Lasswell
2017-08-08 1:15 ` npostavs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efsm507x.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24402@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=gazally@runbox.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.