all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: ahyatt@gmail.com, 3418@debbugs.gnu.org, garyo@genarts.com
Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function
Date: Sat, 12 Aug 2017 11:42:05 -0400	[thread overview]
Message-ID: <87efsg23oy.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83378ysjcc.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2017 09:34:59 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> We could do something like
>> 
>>     (condition-case err
>>         (funcall compilation-parse-errors-filename-function filename spec-dir)
>>       (wrong-number-of-arguments
>>        ;; Try again with single arg for backwards compatibility.
>>        (funcall compilation-parse-errors-filename-function filename)))
>
> Or use func-arity?

I think func-arity could fail in case the function is advised or created
with `apply-partially'.  On the other hand the condition-case trick can
cause problems if there is an unrelated wrong arguments error inside the
function (perhaps this can be migitated by checking the error
information).  Doesn't really matter too much either way I guess, it's
all minor corner cases.






      reply	other threads:[~2017-08-12 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 14:46 bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Gary Oberbrunner
2016-01-26  5:21 ` Andrew Hyatt
2016-01-26 14:42   ` Eli Zaretskii
2016-01-26 15:15     ` Gary Oberbrunner
2016-01-26 16:08       ` Eli Zaretskii
2016-01-26 16:19         ` Gary Oberbrunner
2017-08-11  0:50           ` npostavs
2017-08-11  1:04             ` Gary Oberbrunner
2017-08-11  6:34             ` Eli Zaretskii
2017-08-12 15:42               ` npostavs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efsg23oy.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=3418@debbugs.gnu.org \
    --cc=ahyatt@gmail.com \
    --cc=eliz@gnu.org \
    --cc=garyo@genarts.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.