From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Thu, 05 Oct 2017 11:42:54 +0200 Message-ID: <87efqikk0x.fsf@gmail.com> References: <59CB5D69.7040404@gmx.at> <59CE05F2.1010202@gmx.at> <59CE8E74.5010308@gmx.at> <59D35549.6030905@gmx.at> <87wp4c750c.fsf@gmail.com> <59D4A45F.5010606@gmx.at> <87tvzfjfcp.fsf@gmail.com> <59D5E8F6.8080002@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507196656 8335 195.159.176.226 (5 Oct 2017 09:44:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 09:44:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: Ola Nilsson , Lars Magne Ingebrigtsen , 28605@debbugs.gnu.org, Kaushal To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 11:44:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e02hO-0001X3-Tk for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 11:44:11 +0200 Original-Received: from localhost ([::1]:38692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e02hW-0001ap-DB for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 05:44:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e02hJ-0001W6-PG for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 05:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e02hG-0000LG-NI for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 05:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e02hG-0000Kt-IX for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 05:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e02hG-0000DA-CC for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 05:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28605-submit@debbugs.gnu.org id=B28605.1507196586698 (code B ref 28605); Thu, 05 Oct 2017 09:44:02 +0000 Original-Received: (at 28605) by debbugs.gnu.org; 5 Oct 2017 09:43:06 +0000 Original-Received: from localhost ([127.0.0.1]:49734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e02gM-0000BB-Bs for submit@debbugs.gnu.org; Thu, 05 Oct 2017 05:43:06 -0400 Original-Received: from mail-wm0-f52.google.com ([74.125.82.52]:47279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e02gK-0000Ag-NQ for 28605@debbugs.gnu.org; Thu, 05 Oct 2017 05:43:05 -0400 Original-Received: by mail-wm0-f52.google.com with SMTP id t69so963582wmt.2 for <28605@debbugs.gnu.org>; Thu, 05 Oct 2017 02:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=s+VIoFAUNqt+Jm3BXTSNYgTs/v5WduLLOQJPlWy3aCE=; b=YvB5oPjR4WZvkR/5uXduYB5zRMs5rzMgXNBB8KXsRvgT4bKifdPv6C5v/oU8vnl8n8 mka18LkOMMOkF6/MG9SOyKOqGzdX4IWKfUwKkSVCS/oHQlg28lRoCaM3xhcvaEziPk5E Ip9EuMIAkJXPNVqSfay9T6SuRIuaM+rcnJQzC3pHbrXTY0s3+csZ07OCOvq5QDaei9yX TS2Rva5RQsYxD8o3AnOJjJk+qMhHpb0vtvYC1C+pcNw4hrTVLrg6xNM56jLrfIZZ10MX QkOGNUV1fgSgEQwauCGM1yacjkDarJaKBucPMb87c9q8ZoRmGhBCFeqET+zGK4wIi2Gd iYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=s+VIoFAUNqt+Jm3BXTSNYgTs/v5WduLLOQJPlWy3aCE=; b=QgFJ4h/kMMgbJCJIMwB+G4yhZ0dPXpHFwYkpv0rI1ON7hcng4Oq5iFlAwqskdmMYij shgMGTdiZnPRW3aORsYnI9PeAvAsf+cA5tZc3kDhRLzhpmEl2S107xoGGQcPzWXyvCtR vHFjTUx+ow+tM11cbtbZnQhvcdK2KpwQPqhsFeUdiEsWqH24FRhRYTouohzVB9qmaPYH gkli3m8sg8SUkG6bhr4ShYBJEJMpHoLCg9CAecQogcOtIod6Gnhvrm8lt/V2cETrW1pA uBZ+hxxPG0m9tvtRZ/WyjF+S/NgAj3+6AHGS6+UVETQAWiw1A2zHUPBR3/JdJV9NpnGR jHfw== X-Gm-Message-State: AHPjjUh4NdoD2bwXzOUJYWEbntuGzkrL76w7VJoAlTtlPtEzfUudloSX /2nclQEAjqSxPmU/pk9ZvB4= X-Google-Smtp-Source: AOwi7QAtpj6yqrFk8QXEd0uHqTPrqx0yW17rcr/QUGPUrOElGS8MBG5SpUqwOOKALVEYLJAg7moPPQ== X-Received: by 10.28.71.211 with SMTP id m80mr20680963wmi.158.1507196578747; Thu, 05 Oct 2017 02:42:58 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id o59sm35170519wrc.45.2017.10.05.02.42.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Oct 2017 02:42:57 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <59D5E8F6.8080002@gmx.at> (martin rudalics's message of "Thu, 05 Oct 2017 10:10:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137948 Archived-At: martin rudalics writes: >> Yes, I think removing the calculation for left is the correct fix (at >> least it looks correct here). The horizontal scrollbars need fixing as >> well, see below. > > Looks good to me. Ola, can you check whether Robert's patch fixes > horizontal scroll bars on your system? The horizontal fix is somewhat cargo-culted from the vertical case, so I'm not 100% sure that this hunk is correct (why is it only adjusting the width and the x position? Should it adjust the height/y for the horizontal case?): + { + /* Clear under old scroll bar position. */ + oldw += (scale - 1) * oldw; + oldx -= (scale - 1) * oldw; + x_clear_area (f, oldx, oldy, oldw, oldh); + } >> xg_update_scrollbar_pos and xg_update_horizontal_scrollbar_pos >> are now 99% identical apart from the 'hidden' check. > > Could you refactor them? Not until I or somebody else understands them better :-) > Note that unless you have done so already, you > will probably have to sign papers anyway so that we can install your > patch. If you don't sign, we can probably apply the fix for vertical > scroll bars at most. Eli will decide how to proceed then. I sent off a request to assign@gnu.org more than a month ago, and have heard nothing back (and have also pinged the copyright clerk at the FSF). Help? Worst case I can put the changes in the public domain. >> I don't think this will be the final version: I sometimes get the echo >> area being the wrong size... > > How? Is the mode line of the window above fully visible or does the > horizontal scroll bar overdraw the mode line of its window and the echo > area? False alarm. Looks like my window manager is not giving Emacs the correct height when I maximize the frame, so the window behind it was showing through (although I guess that could also be an Emacs bug, just not related to this one, since it happens without scroll bars). Robert