From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Something weird with when-let*/if-let* Date: Sat, 14 Oct 2017 21:13:45 +0200 Message-ID: <87efq51r12.fsf@ericabrahamsen.net> References: <877evy2am9.fsf@ericabrahamsen.net> <87shel27rc.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508008581 22129 195.159.176.226 (14 Oct 2017 19:16:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 19:16:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 14 21:16:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Rup-0003zZ-3J for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 21:16:07 +0200 Original-Received: from localhost ([::1]:54996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Ruw-00014m-Jl for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 15:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3RuI-00014g-2X for emacs-devel@gnu.org; Sat, 14 Oct 2017 15:15:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3RuE-00043p-R5 for emacs-devel@gnu.org; Sat, 14 Oct 2017 15:15:34 -0400 Original-Received: from [195.159.176.226] (port=46102 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3RuE-00043h-JN for emacs-devel@gnu.org; Sat, 14 Oct 2017 15:15:30 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e3Ru0-0006Ff-Mt for emacs-devel@gnu.org; Sat, 14 Oct 2017 21:15:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 44 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:xtcMW0UgQkejG8z0iXQh3ufpWpk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219527 Archived-At: Noam Postavsky writes: > On Sat, Oct 14, 2017 at 9:47 AM, Noam Postavsky > wrote: >> On Sat, Oct 14, 2017 at 9:12 AM, Eric Abrahamsen >> wrote: >> >>>> The problem is simply that if-let* and when-let* don't exist in emacs 25. >>> >>> That was probably the case there, but that wouldn't explain Julien's >>> report, he's on master. And removing the star fixed it for him. >> >> It could be that subr-x wasn't loaded, which would also have the >> effect of if-let* and when-let* not existing. Although that wouldn't >> directly explain the non-star version working, perhaps when removing >> the star, subr-x got loaded? Seems especially likel > > Oops, hit send too early. I meant to say that it could easily happen > in an interactive session, e.g., due to help-fns loading > (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28607). > >> nnimap.el doesn't explicitly require subr-x. It used to be required in >> message.el, until read-multiple-choice was moved to a separate file[1: >> 295457ae52], now it requires subr-x at compile time [2: 2d58d51329], >> but perhaps it doesn't work for nnimap.el depending on the order of >> compilation? >> >> [1: 295457ae52]: 2017-10-06 10:42:06 -0400 >> Move read-multiple-choice to its own library >> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=295457ae52eda341967821ebc5c053db1789b7c9 >> >> [2: 2d58d51329]: 2017-10-06 20:49:39 +0300 >> Avoid byte-compilation warnings in message.el >> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2d58d513290f08819699e933bb0fbe88362c2131 This sounds pretty likely. What actually determines the order of compilation, btw? I can see how the chain of requires spreads out, but I don't know where it starts. Anyway, testing whether this is actually the source of the problem won't be hard, I'll do it in the next day or so. Thanks, Eric