From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: Something weird with when-let*/if-let*
Date: Sat, 14 Oct 2017 21:13:45 +0200 [thread overview]
Message-ID: <87efq51r12.fsf@ericabrahamsen.net> (raw)
In-Reply-To: CAM-tV-86xUaT-MrcF80RKhdPY=WqrAaJEdj+AXoAmiOwi3+8QQ@mail.gmail.com
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> On Sat, Oct 14, 2017 at 9:47 AM, Noam Postavsky
> <npostavs@users.sourceforge.net> wrote:
>> On Sat, Oct 14, 2017 at 9:12 AM, Eric Abrahamsen
>> <eric@ericabrahamsen.net> wrote:
>>
>>>> The problem is simply that if-let* and when-let* don't exist in emacs 25.
>>>
>>> That was probably the case there, but that wouldn't explain Julien's
>>> report, he's on master. And removing the star fixed it for him.
>>
>> It could be that subr-x wasn't loaded, which would also have the
>> effect of if-let* and when-let* not existing. Although that wouldn't
>> directly explain the non-star version working, perhaps when removing
>> the star, subr-x got loaded? Seems especially likel
>
> Oops, hit send too early. I meant to say that it could easily happen
> in an interactive session, e.g., due to help-fns loading
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28607).
>
>> nnimap.el doesn't explicitly require subr-x. It used to be required in
>> message.el, until read-multiple-choice was moved to a separate file[1:
>> 295457ae52], now it requires subr-x at compile time [2: 2d58d51329],
>> but perhaps it doesn't work for nnimap.el depending on the order of
>> compilation?
>>
>> [1: 295457ae52]: 2017-10-06 10:42:06 -0400
>> Move read-multiple-choice to its own library
>> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=295457ae52eda341967821ebc5c053db1789b7c9
>>
>> [2: 2d58d51329]: 2017-10-06 20:49:39 +0300
>> Avoid byte-compilation warnings in message.el
>> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2d58d513290f08819699e933bb0fbe88362c2131
This sounds pretty likely. What actually determines the order of
compilation, btw? I can see how the chain of requires spreads out, but I
don't know where it starts.
Anyway, testing whether this is actually the source of the problem won't
be hard, I'll do it in the next day or so.
Thanks,
Eric
next prev parent reply other threads:[~2017-10-14 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 12:10 Something weird with when-let*/if-let* Eric Abrahamsen
2017-10-14 13:10 ` Noam Postavsky
2017-10-14 13:12 ` Eric Abrahamsen
2017-10-14 13:47 ` Noam Postavsky
2017-10-14 13:49 ` Noam Postavsky
2017-10-14 19:13 ` Eric Abrahamsen [this message]
2017-10-14 19:55 ` Noam Postavsky
2017-10-14 20:03 ` Eric Abrahamsen
2017-10-14 20:05 ` Eric Abrahamsen
2017-10-14 20:42 ` Stefan Monnier
2017-10-16 3:23 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efq51r12.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.