all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Alan Mackenzie <acm@muc.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>,
	"npostavs@gmail.com" <npostavs@gmail.com>,
	zhang cc <ccsmile2008@outlook.com>
Subject: Re: beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode]
Date: Sun, 07 Jan 2018 07:25:04 +0100	[thread overview]
Message-ID: <87efn2fanz.fsf@mbork.pl> (raw)
In-Reply-To: <20180106120002.GA23284@ACM>


On 2018-01-06, at 13:00, Alan Mackenzie <acm@muc.de> wrote:

> There was a long discussion about this and related matters on
> emacs-devel about a year ago, I think.  I'm assuming that this marking of
> the preceding comment is in accordance with that thread on emacs-devel.

More or less, yes.

The rationale is that in many languages, the comment preceding the
function is basically its docstring.  Thus marking the function should
also mark that comment.

> I've committed the change to the emacs-26 branch.

Thanks a lot for working on this.

Best,

-- 
Marcin Borkowski



  parent reply	other threads:[~2018-01-07  6:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30  9:49 26.0.90: mark-defun problem in c-mode zhang cc
2017-12-30 10:30 ` Eli Zaretskii
2017-12-30 10:34   ` Alan Mackenzie
2017-12-30 12:01     ` beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode] Alan Mackenzie
2017-12-30 12:53       ` Eli Zaretskii
2017-12-30 13:05         ` Alan Mackenzie
2018-01-03  4:51           ` Marcin Borkowski
2018-01-03 16:24             ` Alan Mackenzie
2018-01-05 14:55               ` zhang cc
2018-01-06 12:00                 ` Alan Mackenzie
2018-01-06 13:54                   ` zhang cc
2018-01-07  6:25                   ` Marcin Borkowski [this message]
2018-03-26  6:57               ` Marcin Borkowski
2017-12-30 15:43         ` Alan Mackenzie
2017-12-30 18:43           ` Stephen Leake
2017-12-31 10:55             ` Alan Mackenzie
2017-12-31  4:26           ` Stefan Monnier
2017-12-31 10:50             ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efn2fanz.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=acm@muc.de \
    --cc=ccsmile2008@outlook.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.