From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: talchas@talchas.net Newsgroups: gmane.emacs.bugs Subject: bug#30203: 25.3; without-xft fonts don't properly inherit from default face Date: Mon, 22 Jan 2018 08:59:52 -0800 Message-ID: <87efmh7rsn.fsf@talchas.net> References: <877esazctz.fsf@talchas.net> <83k1w9rizl.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516640662 8550 195.159.176.226 (22 Jan 2018 17:04:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 17:04:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: talchas@talchas.net, 30203@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 22 18:04:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edfVm-0000ot-Hs for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 18:03:58 +0100 Original-Received: from localhost ([::1]:53317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edfXm-0005Eq-Q1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 12:06:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edfT2-0001hJ-EG for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 12:01:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edfSw-0005XI-QO for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 12:01:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edfSw-0005X7-N8 for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 12:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edfSv-0001SD-NJ for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 12:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: talchas@talchas.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jan 2018 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30203 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30203-submit@debbugs.gnu.org id=B30203.15166404085524 (code B ref 30203); Mon, 22 Jan 2018 17:01:01 +0000 Original-Received: (at 30203) by debbugs.gnu.org; 22 Jan 2018 17:00:08 +0000 Original-Received: from localhost ([127.0.0.1]:38368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edfS3-0001R0-Ul for submit@debbugs.gnu.org; Mon, 22 Jan 2018 12:00:08 -0500 Original-Received: from mail-pf0-f181.google.com ([209.85.192.181]:45580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edfS2-0001P7-8n for 30203@debbugs.gnu.org; Mon, 22 Jan 2018 12:00:06 -0500 Original-Received: by mail-pf0-f181.google.com with SMTP id a88so7523299pfe.12 for <30203@debbugs.gnu.org>; Mon, 22 Jan 2018 09:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=talchas.net; s=gmail; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6TBcyI4OqP5VC+oS5AXy6A3qE527O5IMLqm61GiL30k=; b=oNJlvdweS97cU4fpSvCzEghaeWBSTziV56gDXo+v4/6U+CyDSwFfJg1+U1Ceen0wGM GqhHEuoo7XFAJyTn3/jQFQPWMsyyjcnQPvPcWrAeqmYMaAdRfoZHXz4jC9i3MypcSci0 mPrvY9XHbFnoq5DbHq65Ov27lWSzFe33LYB20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6TBcyI4OqP5VC+oS5AXy6A3qE527O5IMLqm61GiL30k=; b=FatiiGRRci7QyKp7AfD+jzI9jtsAdBPiit566AluBs0xj5nc0inV/4/hSs/VPO2JxG wnPiOmxvI/TRUeJYJ07J2qUysGQz+H4MpIUL3JAfAbRSe7XeX65ApVfduetOZ8rpQcLo ZXqWqEpjwsilbB6YdA7q2vhCpE2ApaHRTKNGE7WMdZfaMRIBBtSTMJg+NCFysMV0HsBv XBSpIS5U4Vj1JApf6fr3LBSuXQAn4SZUE0BUrFXbhcG1bp2DuNNJtwML+6FFsm/46Syh TKebldK9lchzpaZfs6GACVC4/WyV8wCuNI9w4m2c0jpMykefgGsd4MRY7L/bvVTL6es0 XQdA== X-Gm-Message-State: AKwxytdvaWyozDzi3Sx4e8x/1TjzfP95XtOVrCKWDb8VVRA83ljMHYbW BGE8C68Sq3QFJbfPno6SYt8ymuii X-Google-Smtp-Source: AH8x227nw6ld9VJhBDd9r2R949ZmnQEjgeE3oWjoYdDPy1gcutTAkmIiVfytXT2RsLRH85WmdFnbuw== X-Received: by 10.99.99.129 with SMTP id x123mr7714211pgb.437.1516640399991; Mon, 22 Jan 2018 08:59:59 -0800 (PST) Original-Received: from nights-beautiful-daughter.localhost (c-69-181-143-71.hsd1.ca.comcast.net. [69.181.143.71]) by smtp.gmail.com with ESMTPSA id d5sm2652794pfk.2.2018.01.22.08.59.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 08:59:58 -0800 (PST) In-Reply-To: <83k1w9rizl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Jan 2018 17:49:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142382 Archived-At: Eli Zaretskii writes: >> From: talchas@talchas.net >> Date: Sun, 21 Jan 2018 21:23:20 -0800 >> >> When built without xft, faces that specify weight such as bold don't >> take their family from the default face if it doesn't match weight. >> >> You can see this with: >> emacs -Q >> (set-frame-font "-xos4-terminus-medium-r-normal--14-*-72-72-c-80-iso10646-1") >> >> and look at the mode line buffer display - on my system it is >> -misc-fixed-... according to dump-face. This still occurs on git HEAD >> (b3fb0d47c158cb0d1acdce5008628e1d1a337bbb) as well as the system 25.3 below. >> >> When built with xft this does not occur (still selected via the X font >> name), and neither does it on 24.5. The proximate cause of the >> regression appears to be bf0d3f76dcfe7881cb3058169b51cf6602fdcdcb, >> reversing the >> >> - = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]); >> + = font_load_for_lface (f, attrs, Ffont_spec (0, NULL)); >> >> gives the old behavior despite --without-xft. Given that xft is fine >> on 25.3, there presumably is some more correct fix to font selection. > > That change was made to fix two bugs, whose numbers are mentioned in > the log entry and in the discussion of the bug. Can you try > reproducing those bugs in the build without xft? If those bugs only > happen with xft, then the fix is easy. Otherwise, we will have to > investigate more thoroughly. > > Thanks. Unfortunately not, reverting that hunk goes from a very thin space to a large missing-character symbol, and reverting the patch entirely just gives a full space again.