From: talchas@talchas.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: talchas@talchas.net, 30203@debbugs.gnu.org
Subject: bug#30203: 25.3; without-xft fonts don't properly inherit from default face
Date: Mon, 22 Jan 2018 08:59:52 -0800 [thread overview]
Message-ID: <87efmh7rsn.fsf@talchas.net> (raw)
In-Reply-To: <83k1w9rizl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Jan 2018 17:49:50 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: talchas@talchas.net
>> Date: Sun, 21 Jan 2018 21:23:20 -0800
>>
>> When built without xft, faces that specify weight such as bold don't
>> take their family from the default face if it doesn't match weight.
>>
>> You can see this with:
>> emacs -Q
>> (set-frame-font "-xos4-terminus-medium-r-normal--14-*-72-72-c-80-iso10646-1")
>>
>> and look at the mode line buffer display - on my system it is
>> -misc-fixed-... according to dump-face. This still occurs on git HEAD
>> (b3fb0d47c158cb0d1acdce5008628e1d1a337bbb) as well as the system 25.3 below.
>>
>> When built with xft this does not occur (still selected via the X font
>> name), and neither does it on 24.5. The proximate cause of the
>> regression appears to be bf0d3f76dcfe7881cb3058169b51cf6602fdcdcb,
>> reversing the
>>
>> - = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
>> + = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
>>
>> gives the old behavior despite --without-xft. Given that xft is fine
>> on 25.3, there presumably is some more correct fix to font selection.
>
> That change was made to fix two bugs, whose numbers are mentioned in
> the log entry and in the discussion of the bug. Can you try
> reproducing those bugs in the build without xft? If those bugs only
> happen with xft, then the fix is easy. Otherwise, we will have to
> investigate more thoroughly.
>
> Thanks.
Unfortunately not, reverting that hunk goes from a very thin space to a
large missing-character symbol, and reverting the patch entirely just
gives a full space again.
prev parent reply other threads:[~2018-01-22 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 5:23 bug#30203: 25.3; without-xft fonts don't properly inherit from default face talchas
2018-01-22 15:49 ` Eli Zaretskii
2018-01-22 16:59 ` talchas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efmh7rsn.fsf@talchas.net \
--to=talchas@talchas.net \
--cc=30203@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.