From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30215: Visiting files from zip archives should not modify directory time Date: Wed, 24 Jan 2018 23:36:10 +0200 Organization: LINKOV.NET Message-ID: <87efmfuegl.fsf@mail.linkov.net> References: <87mv157e8f.fsf@mail.linkov.net> <83h8rco7cg.fsf@gnu.org> <87tvvc8ds1.fsf@mail.linkov.net> <83zi53m6za.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516830264 16252 195.159.176.226 (24 Jan 2018 21:44:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Jan 2018 21:44:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30215@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 24 22:44:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeSq7-0003fH-4V for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 22:44:15 +0100 Original-Received: from localhost ([::1]:48586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeSs7-0002OO-MW for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 16:46:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeSrt-0002Mu-Sf for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 16:46:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeSrq-0005CN-Os for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 16:46:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeSrq-0005CC-LG for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 16:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeSrq-0005OU-FH for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2018 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30215-submit@debbugs.gnu.org id=B30215.151683032120668 (code B ref 30215); Wed, 24 Jan 2018 21:46:02 +0000 Original-Received: (at 30215) by debbugs.gnu.org; 24 Jan 2018 21:45:21 +0000 Original-Received: from localhost ([127.0.0.1]:41410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeSrA-0005NH-Qy for submit@debbugs.gnu.org; Wed, 24 Jan 2018 16:45:21 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:43946 helo=homiemail-a21.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeSr8-0005N8-2q for 30215@debbugs.gnu.org; Wed, 24 Jan 2018 16:45:19 -0500 Original-Received: from homiemail-a21.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTP id 28D1B1C0065; Wed, 24 Jan 2018 13:45:17 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-107-35.cust.tele2.ee [91.129.107.35]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTPSA id 4912B1C0064; Wed, 24 Jan 2018 13:45:15 -0800 (PST) In-Reply-To: <83zi53m6za.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Jan 2018 20:44:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142485 Archived-At: > If that's the problem, then I think it would be cleaner to disable > creation of lock files and backup files by less subtle means -- by > let-binding create-lockfiles and make-backup-files. Doing that by > leaving buffer-file-truename at nil leaves the code less clear IMO, > and relies on assumptions that might not hold at some future point. Thanks for the suggestion, this is better indeed: diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index adb3669..4fe1b03 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -807,7 +807,7 @@ archive-summarize Optional argument SHUT-UP, if non-nil, means don't print messages when parsing the archive." (widen) - (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file + (let ((create-lockfiles nil) ; avoid changing dir mtime by lock_file (inhibit-read-only t)) (setq archive-proper-file-start (copy-marker (point-min) t)) (set (make-local-variable 'change-major-mode-hook) 'archive-desummarize) @@ -1064,7 +1064,9 @@ archive-extract ;; We read an archive member by no-conversion at ;; first, then decode appropriately by calling ;; archive-set-buffer-as-visiting-file later. - (coding-system-for-read 'no-conversion)) + (coding-system-for-read 'no-conversion) + ;; Avoid changing dir mtime by lock_file + (create-lockfiles nil)) (condition-case err (if (fboundp extractor) (funcall extractor archive ename)