all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 30675@debbugs.gnu.org, Katsumi Yamaoka <yamaoka@jpl.org>
Subject: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size
Date: Thu, 01 Mar 2018 21:51:36 -0500	[thread overview]
Message-ID: <87efl342br.fsf@gmail.com> (raw)
In-Reply-To: <87po4n19q0.fsf_-_@jidanni.org> ("積丹尼 Dan Jacobson"'s message of "Fri, 02 Mar 2018 10:40:07 +0800")

severity 30675 wishlist
quit

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> Instead of warning the user when this happens
>
> KY> (defun shr-descend (dom)
> KY>   ...
> KY>     (if (> shr-depth (/ max-specpdl-size 15))
> KY> 	(setq shr-warning "Too deeply nested to render properly; consider increasing `max-specpdl-size'")
> KY>       else ...))
>
> it should ask the user "Should we try 15 levels deeper? y-n
>
> and if that is still not enough,
>
> it should ask the user "Should we try 25 levels even more deeper? y-n
> ...
>
> Why?
>
> Because the user is facing a probably one-time bad html message.
>
> He doesn't want to change his .emacs to always let them pass.
>
> He also wants the choice:
> no I don't want to go deeper for this promotional coupon.
> yes my grandmom sent me this so I want to see it.

On the other hand, if you say go deeper too far Emacs will crash.  It's
a bit hard to predict how far is too far, so I'm not sure if this prompt
is such a great idea.  See Bug#16999 "calc crashes when computation
limit is increased" for an example of such a prompt.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=16999





  reply	other threads:[~2018-03-02  2:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877eqwbqvc.fsf@jidanni.org>
     [not found] ` <b4mfu5kk0iz.fsf@jpl.org>
2018-03-02  2:40   ` bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size 積丹尼 Dan Jacobson
2018-03-02  2:51     ` Noam Postavsky [this message]
2018-04-12 23:49     ` Lars Ingebrigtsen
2018-04-13  0:06       ` 積丹尼 Dan Jacobson
2018-04-13  0:27         ` Lars Ingebrigtsen
2018-04-13  9:29           ` Eli Zaretskii
2018-04-13 11:48             ` Lars Ingebrigtsen
2018-04-13 12:15               ` Noam Postavsky
2018-04-13 12:32                 ` Lars Ingebrigtsen
2018-04-13 12:43               ` Eli Zaretskii
2018-04-13 15:34                 ` Lars Ingebrigtsen
2018-04-15 17:02                   ` Lars Ingebrigtsen
2018-04-13 12:40             ` 積丹尼 Dan Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efl342br.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=30675@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.