From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Heads-up: Emacs 26.1 RC1 Date: Wed, 21 Mar 2018 07:22:48 +0800 Message-ID: <87efke5o3b.fsf@ericabrahamsen.net> References: <83605snjjt.fsf@gnu.org> <87605raoo9.fsf@killashandra.ballybran.fr> <83zi33n9ud.fsf@gnu.org> <87y3inalb5.fsf@killashandra.ballybran.fr> <83sh8vn7ss.fsf@gnu.org> <87r2of5las.fsf@ericabrahamsen.net> <83d0zzmd3b.fsf@gnu.org> <87muz35f33.fsf@ericabrahamsen.net> <83bmfjm7ew.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521588210 27642 195.159.176.226 (20 Mar 2018 23:23:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 23:23:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: johnw@gnu.org, emacs-devel@gnu.org, pierre.techoueyres@free.fr To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 21 00:23:26 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyQbG-00075F-6W for ged-emacs-devel@m.gmane.org; Wed, 21 Mar 2018 00:23:26 +0100 Original-Received: from localhost ([::1]:52096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyQdJ-0006mC-Ee for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 19:25:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyQdB-0006ll-6r for emacs-devel@gnu.org; Tue, 20 Mar 2018 19:25:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyQdA-0007kW-9M for emacs-devel@gnu.org; Tue, 20 Mar 2018 19:25:25 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:59998) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyQd6-0007is-9b; Tue, 20 Mar 2018 19:25:20 -0400 Original-Received: from localhost (unknown [172.56.13.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E5494C0A5C; Tue, 20 Mar 2018 23:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1521588319; bh=F1J8CB/KTbRyBTpvwV4d8vv/UctN9a7X7LQIIsfwgU8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=uqyWGofvczHVa2OWDZRg9ynKDh5jprhNL5h25yHrt1/hJYQbvm1zPE/AykSvYRo+4 CL3wCMs/l2VW53If7aduDezsPuOSM1PGbFiWIbtw75Yiu58hhbEvyjtuu4LvzhDyvK AD2cCWCFwjJw6minUMdnWVsa4RYMxIwYWGoyNnMU= In-Reply-To: <83bmfjm7ew.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Mar 2018 11:18:47 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 50.56.99.223 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223866 Archived-At: On 03/20/18 11:18 AM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: pierre.techoueyres@free.fr, johnw@gnu.org, emacs-devel@gnu.org >> Date: Tue, 20 Mar 2018 16:25:04 +0800 >> >> > The changes in error/warning messages and in the test suite are okay >> > to go, but I'm worried by the 2 changes that add a condition (where >> > you went from (when ...) to (cond ...)). Is this really necessary, >> > and what problems do they solve? >> >> I know... Mostly it took so long because of testing. The test suite >> changes are there to test the new code, which directly models errors >> currently in the wild, and they can't go in by themselves. >> >> Very long story short, in Emacs 26 eieio objects went from being defined >> as vectors to being defined as objects. This messed up how they are >> serialized to disk using eieio-persistent. Two main consumers of >> eieio-persistent (pcache and the Gnus registry) are currently broken >> because of this. The `cond' statement is there to make sure that, in >> these two packages, the objects are written correctly to disk. > > Which code/packages outside of CEDET use the affected functions? Pcache is a big one, as several other packages depend on it -- though I haven't been able to figure out exactly how many from the Melpa repo. It currently errors loudly. The Gnus repository is another, and it is silently corrupted. Those are the main two, and the code changes (though they look large) are specifically targeted at those two packages. A more general solution is in the works for 27, but this was the smallest diff I could manage that fixes the problem.