From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: johnw@gnu.org, emacs-devel@gnu.org, pierre.techoueyres@free.fr
Subject: Re: Heads-up: Emacs 26.1 RC1
Date: Wed, 21 Mar 2018 07:22:48 +0800 [thread overview]
Message-ID: <87efke5o3b.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <83bmfjm7ew.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Mar 2018 11:18:47 +0200")
On 03/20/18 11:18 AM, Eli Zaretskii wrote:
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Cc: pierre.techoueyres@free.fr, johnw@gnu.org, emacs-devel@gnu.org
>> Date: Tue, 20 Mar 2018 16:25:04 +0800
>>
>> > The changes in error/warning messages and in the test suite are okay
>> > to go, but I'm worried by the 2 changes that add a condition (where
>> > you went from (when ...) to (cond ...)). Is this really necessary,
>> > and what problems do they solve?
>>
>> I know... Mostly it took so long because of testing. The test suite
>> changes are there to test the new code, which directly models errors
>> currently in the wild, and they can't go in by themselves.
>>
>> Very long story short, in Emacs 26 eieio objects went from being defined
>> as vectors to being defined as objects. This messed up how they are
>> serialized to disk using eieio-persistent. Two main consumers of
>> eieio-persistent (pcache and the Gnus registry) are currently broken
>> because of this. The `cond' statement is there to make sure that, in
>> these two packages, the objects are written correctly to disk.
>
> Which code/packages outside of CEDET use the affected functions?
Pcache is a big one, as several other packages depend on it -- though I
haven't been able to figure out exactly how many from the Melpa repo. It
currently errors loudly. The Gnus repository is another, and it is
silently corrupted. Those are the main two, and the code changes (though
they look large) are specifically targeted at those two packages. A more
general solution is in the works for 27, but this was the smallest diff
I could manage that fixes the problem.
next prev parent reply other threads:[~2018-03-20 23:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 15:59 Heads-up: Emacs 26.1 RC1 Eli Zaretskii
2018-03-19 18:46 ` Pierre Téchoueyres
2018-03-19 19:28 ` Eli Zaretskii
2018-03-19 19:59 ` Pierre Téchoueyres
2018-03-19 20:12 ` Eli Zaretskii
2018-03-20 6:10 ` Eric Abrahamsen
2018-03-20 7:16 ` Eli Zaretskii
2018-03-20 8:25 ` Eric Abrahamsen
2018-03-20 9:18 ` Eli Zaretskii
2018-03-20 23:22 ` Eric Abrahamsen [this message]
2018-03-20 23:33 ` Dmitry Gutov
2018-03-21 0:11 ` Eric Abrahamsen
2018-03-21 6:34 ` Eli Zaretskii
2018-03-21 9:48 ` Eric Abrahamsen
2018-03-21 9:57 ` Eric Abrahamsen
2018-03-21 12:54 ` Eli Zaretskii
2018-03-21 13:50 ` Eric Abrahamsen
2018-03-22 19:38 ` Pierre Téchoueyres
2018-03-19 21:00 ` Michael Heerdegen
2018-03-20 7:03 ` Eli Zaretskii
2018-03-26 18:53 ` Eli Zaretskii
2018-03-26 20:05 ` Michael Heerdegen
2018-03-27 0:01 ` Michael Heerdegen
2018-03-27 2:40 ` Eli Zaretskii
2018-03-27 2:58 ` Michael Heerdegen
2018-03-27 3:12 ` Eli Zaretskii
2018-03-19 21:04 ` Phillip Lord
2018-03-19 21:11 ` Noam Postavsky
2018-03-20 7:05 ` Eli Zaretskii
2018-03-20 10:31 ` Phillip Lord
2018-03-19 21:33 ` Richard Copley
2018-03-20 7:08 ` Eli Zaretskii
2018-03-20 9:52 ` Robert Pluim
2018-03-20 12:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efke5o3b.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
--cc=pierre.techoueyres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.