From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Date: Sun, 06 May 2018 10:14:13 -0400 Message-ID: <87efiona6i.fsf@gmail.com> References: <87sh747vsf.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1525615989 1087 195.159.176.226 (6 May 2018 14:13:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 May 2018 14:13:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: 31373@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 06 16:13:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFKPP-00007L-B1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 16:13:03 +0200 Original-Received: from localhost ([::1]:42262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFKRW-0003h2-49 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 10:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFKRP-0003gL-N5 for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFKRK-0004Mk-MX for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:15:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFKRK-0004Mg-Gk for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFKRK-0005vS-6T for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 May 2018 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152561607122729 (code B ref -1); Sun, 06 May 2018 14:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 May 2018 14:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:51493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFKQo-0005uX-R1 for submit@debbugs.gnu.org; Sun, 06 May 2018 10:14:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFKQn-0005uK-Oo for submit@debbugs.gnu.org; Sun, 06 May 2018 10:14:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFKQh-0003q7-DY for submit@debbugs.gnu.org; Sun, 06 May 2018 10:14:24 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fFKQh-0003pi-8o for submit@debbugs.gnu.org; Sun, 06 May 2018 10:14:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFKQg-0003Vs-3g for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:14:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFKQb-0003jm-1D for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:14:22 -0400 Original-Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]:45925) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFKQa-0003j1-QJ for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 10:14:16 -0400 Original-Received: by mail-io0-x22b.google.com with SMTP id c9-v6so24356444iob.12 for ; Sun, 06 May 2018 07:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=XZjmws5iEGKoFgtCCRhAnxVrW9uL+flHq4wiEqyjHnA=; b=r7dZ4TNjbbUhMchw5fGFFBwZlOyHBlmJQ5mohDNB+BWSKMLSGmiOVs6yMDSOUuN/T0 5Jiaup1mmJLCcv0JzIFDCnlGz5RKC5mZVQHl8ZHOW/tZZZsnAWV9jsv5WPjoT9dThwXb FCs9JZAJO10xV8SMAMqEWYJ6zRsUMnspXC9a6x6pnOJpdsoGC00KYnqwDYW20tQRL5zF qoTXbVz7wJfBZS5wruV5G7aF8zqCPweDoGaPwPMH4hwIwHMMKROu1u9Rc+DigJhTUxxm nvbWMkKt5KlIbn5ikeb4TsKOdo1KkucIZwAgkEb0KcIAqHyDe334Ew2TVhA2zCpLUPAf bsxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XZjmws5iEGKoFgtCCRhAnxVrW9uL+flHq4wiEqyjHnA=; b=GU53JxrYVUVUGstWMOZW7BqKfgFKIWdlIpz7E7FBVIym+CNeVYH3rckyVo6plAinmF SYf5AUsmJfAa2Ha9y/w01EjMD3e+G7Ify+fjDSrLJkSHGBhogJakeZpDGRL2jy52cuF6 rKg17qY2y5TQqIuR+qKiUfvmFmt0ozCVSF0gB6k2N1flZ3WnNkAOdSM0+EHz/bgXk46v ZjbU4qR2reUpa2R3GBEFMMOIb5458X75ehQjZHrYP7RD/S29D3ESiq9/jMDNWuwpfnfc h7tcc/A24Cx554lsxvEPQ7ZxQk39SvTQK3mRYxW9Djrl7N+mOnooMZdcWaxoxjY+/RmD Fa5Q== X-Gm-Message-State: ALQs6tCP6h60GHBnJ7PT3zAf5jiJqZvHcrtBLDwv4PZ/+moxgD9JQMo0 t2oZuJpSOCaFKow5ColKGL/8wA== X-Google-Smtp-Source: AB8JxZqeUvDpe4QeUvGRH9O2DdfL8qFl6CNRCkVDIirZ11glK7YTWzWO1eu/am8ZQqXROWZ9NGq0GA== X-Received: by 2002:a6b:9e42:: with SMTP id h63-v6mr37421847ioe.30.1525616056212; Sun, 06 May 2018 07:14:16 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h68-v6sm3169798ith.28.2018.05.06.07.14.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 May 2018 07:14:15 -0700 (PDT) In-Reply-To: <87sh747vsf.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 06 May 2018 14:34:08 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146042 Archived-At: --=-=-= Content-Type: text/plain tags 31373 + patch quit "Basil L. Contovounesios" writes: > On the latest emacs-26 and master branches, calling the function > frame-list-z-order crashes a daemon Emacs via segfault: > > 1. ./src/emacs -Q --daemon= > 2. ./lib-src/emacsclient --socket-name= --create-frame > 3. cd src > 4. gdb -p > 5. Issue 'continue' in gdb You can also use 1. gdb ./emacs -Q --fg-daemon= 2. Issue 'run' in gdb 3. ../lib-src/emacsclient --socket-name= --create-frame > 6. Evaluating (frame-list-z-order) in the emacsclient frame gives the > following output in gdb: > > Thread 1 "emacs" received signal SIGSEGV, Segmentation fault. > 0x0000000000565112 in x_frame_list_z_order (dpy=0x33018f0, window=227) at xfns.c:5306 > 5306 if (XFRAME (frame)->output_data.x->parent_desc == children[i] > A quick step-through of x_frame_list_z_order indicates that the members > of the struct XFRAME (frame)->output_data are initialised to NULL for > the initial daemon frame F1. Right, I think we need to check the frame's output_method field first. I wonder if there are other cases like this? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-check-non-X-frames-for-z-order-Bug-31373.patch Content-Description: patch >From b2c13a02a88fc8cc00c61ef8f56719fbb9b02897 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 6 May 2018 10:07:25 -0400 Subject: [PATCH] Don't check non-X frames for z order (Bug#31373) * src/xfns.c (x_frame_list_z_order): Only use frames with `output_method' set to `output_x_window'. --- src/xfns.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xfns.c b/src/xfns.c index 20fe61bffd..29dd529e27 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -5303,8 +5303,9 @@ x_frame_list_z_order (Display* dpy, Window window) /* With a reparenting window manager the parent_desc field usually specifies the topmost windows of our frames. Otherwise FRAME_OUTER_WINDOW should do. */ - if (XFRAME (frame)->output_data.x->parent_desc == children[i] - || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i]) + if (XFRAME (frame)->output_method == output_x_window + && (XFRAME (frame)->output_data.x->parent_desc == children[i] + || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i])) frames = Fcons (frame, frames); } -- 2.11.0 --=-=-=--