From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Date: Thu, 08 Nov 2018 09:52:51 +0000 Message-ID: <87efbvrj4c.fsf@gmail.com> References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541670729 3759 195.159.176.226 (8 Nov 2018 09:52:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2018 09:52:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33301@debbugs.gnu.org, Noam Postavsky To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 08 10:52:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgyp-0000qu-WC for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 10:52:04 +0100 Original-Received: from localhost ([::1]:55480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKh0w-0000KW-0v for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 04:54:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKh0n-0000KK-AK for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKh0k-0007li-46 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:54:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKh0j-0007lU-TX for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKh0j-0003w2-Pb for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2018 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 33301-submit@debbugs.gnu.org id=B33301.154167078615057 (code B ref 33301); Thu, 08 Nov 2018 09:54:01 +0000 Original-Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 09:53:06 +0000 Original-Received: from localhost ([127.0.0.1]:40316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgzn-0003ul-Tg for submit@debbugs.gnu.org; Thu, 08 Nov 2018 04:53:04 -0500 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:40712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgzm-0003uG-6S for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 04:53:02 -0500 Original-Received: by mail-wm1-f48.google.com with SMTP id b203-v6so549913wme.5 for <33301@debbugs.gnu.org>; Thu, 08 Nov 2018 01:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=EgNHcQFpJ955i2TRHeETE7niGbIMtakSSqlGlbnaQxjBqCfi5xLPo+ru7CoKngOLjF S4Dm7CkH2EVjdjAo0dawjcCr/2wCRPBjvb/OPrk55jWf+DZ5uyv+tjhOqIJ42qyLTkos E75NPOhRgItKlN+VfBfA5OxjaZJ0EKz1z7NfcfhrCFAayPAB6JjbSLNlPxOwYFLOGKnU LWdaioit4CrNGQyEPGGCBarl8J3SjnAaMbIZ9/MwRbvi05e+WjXSauGGqu9DAXwkCQUT Tsbgu7fk8XAgOhxYI9Ra1EH3SR2Sa+L/QTwTFuhNksprZVik0Bd4ZI2WGZNTqX3X+iiK ccjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=kd3br5xUIpS3GlrHWSJpnbpIHVkDdlzc7qATYvXt94SRhD96c9r7sS2EoKTy0y5R9V Av2zU1L8yaeNWWIBJwYVjAuTQ9dal0yK9y4veFdz2Swhc3w06x6evzWzGkQHNbyZXKEw CTQMf65RUmyL/YmBnZpt/nvPWAlPW3JHjg9yhTIAyUuOSZiU3fR4ve2C2mskRPyJSgo3 9LPb3XfdOpk4ESSWXAUk3+1y1KBPFEKZZQgOhpd1EpnEy3tUO3AvWpaT1oFwV0gqgKTg m9zn0RhDazbQ+F97NhfnT1uB5xC+MxL9krExsDaup8qO/DVD7pHOCowAdBGDQJj/ZgYF QMoA== X-Gm-Message-State: AGRZ1gJlV1udyt8bVHezbl8K/HtMY2RMCAqLzaJjnnPy0w+lBxzKyw3A 5v5BJEv0ng4c+ZRPpQIYHE96Jc4V X-Google-Smtp-Source: AJdET5cepb3kCJR+OAB+uWMQrAFdHzQ/6JWiBLrEqPYmx6/SKAYcIdI8+U4VZtfOifs0yw4Ka+HMLQ== X-Received: by 2002:a1c:6a09:: with SMTP id f9-v6mr618935wmc.78.1541670775163; Thu, 08 Nov 2018 01:52:55 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id s195-v6sm2635604wmd.39.2018.11.08.01.52.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 01:52:54 -0800 (PST) In-Reply-To: <87tvksv21u.fsf@web.de> (Michael Heerdegen's message of "Thu, 08 Nov 2018 01:35:41 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152154 Archived-At: Michael Heerdegen writes: > Noam Postavsky writes: > >> > (cond (bla >> > ok) >> > (defan >> > strange)) > > That's explicitly done in 'lisp-indent-function': > (and (null method) > (> (length function) 3) > (string-match "\\`def" function))) ;; <=3D=3D Ah, that's unfortunate. Still, coundn't we improve the heuristic by asking if the "function" has a macro definition? Isn't that closer to the intended behaviour? diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index afb7cbd1dd..e7373ece85 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1104,7 +1104,8 @@ lisp-indent-function (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) - (string-match "\\`def" function))) + (string-match "\\`def" function) + (macrop (intern function)))) (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state Jo=C3=A3o