From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: Latex preview fg color w/tikz (known problem, fix
 suggested) [9.1.9 (release_9.1.9-65-g5e4542 @
 /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/org/)]
Date: Thu, 03 Jan 2019 12:35:28 +0100
Message-ID: <87ef9uug73.fsf@nicolasgoaziou.fr>
References: <878t13n5qo.fsf@gmail.com> <87d0qfa6j7.fsf@nicolasgoaziou.fr>
	<CAELgYhcUAneE+0EJ0zwyHcXQYZ+GDtCsDmCj+mtmrWwKKau6hQ@mail.gmail.com>
	<87o99wfije.fsf@nicolasgoaziou.fr> <87mupg3wqt.fsf@gmail.com>
	<CAELgYhfQfoR4eidC96AdpQ_shyLYFd1wwu3wF_UpAG_4YLGTZw@mail.gmail.com>
	<CAELgYhceJbQ1t=qp2mjZoBY2+Yv8QjNU7tv85n11p92wFz9sLw@mail.gmail.com>
	<87sgybumgt.fsf@nicolasgoaziou.fr>
	<CAELgYhfqYsPnwn5iMcQ93LwGcE6Xm-k5qoM_Rt6hgUH-OOJrRg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:49885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gf1Hj-0004BU-Kn
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 06:35:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gf1Hf-0006VZ-NG
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 06:35:35 -0500
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38245)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1gf1Hf-0006Sd-H4
	for emacs-orgmode@gnu.org; Thu, 03 Jan 2019 06:35:31 -0500
In-Reply-To: <CAELgYhfqYsPnwn5iMcQ93LwGcE6Xm-k5qoM_Rt6hgUH-OOJrRg@mail.gmail.com>
	(Carlos Pita's message of "Wed, 2 Jan 2019 19:12:51 -0300")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Carlos Pita <carlosjosepita@gmail.com> writes:

> Here is a patch. It removes quite a few LOC.

Thank you.

> Every other previewer has :use-xcolor t. I assume it's safe to simply
> ignore :use-xcolor if it's there except that some user has configured
> a converter that for some reason requires the color command line args,
> in which case he will get an error (because of the color placeholders
> left untouched in the command line template).

Could you also add an entry in ORG-NEWS, in Incompatible Changes section?

> From 9beda785e60c791bc6524b996b60e9db00f858b7 Mon Sep 17 00:00:00 2001
> From: memeplex <carlosjosepita@gmail.com>
> Date: Wed, 2 Jan 2019 19:05:26 -0300
> Subject: [PATCH] Use xcolor for all latex preview converters

You need to expound a bit the commit message. Please have a look at
other such messages for examples.

Regards,

-- 
Nicolas Goaziou