all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Fernando Jascovich <fernando.ej@gmail.com>
To: 33887@debbugs.gnu.org
Subject: bug#33887: 26.1; Emacs hangs for several seconds when going to the end of an XML file in nXML mode
Date: Tue, 08 Jan 2019 19:11:02 -0300	[thread overview]
Message-ID: <87ef9m2421.fsf@gmail.com> (raw)
In-Reply-To: <87ftujuvkd.fsf@zira.vinc17.org>

Hi everyone, this is my first email to bug-gnu-emacs, so please let me
know if I am making some mistake.
For no special reason, I took this bug in order to start to know  emacs'
code.
Following and confirming the details of the bug, I found that indeed the
performance issue is introduced at commit 0055190174, but not beacuse
the introduction of `sgml-syntax-propertize-inside`.
The problem is with the last rule:
```
("\"" (0 (if (prog1 (zerop (car (syntax-ppss (match-beginning 0))))
                    (goto-char (match-end 0)))
                  (string-to-syntax ".")))
```
I can't see the real effect of this rule, I tested xml parsing without
this rule and it works fine, marking double quotes inside tags as
expected without this performance issue.
Do we need to target double quotes outside tags explicitly?

-- 
Fernando Jascovich
developer
m: +54 9 3548 63 9833
github: https://github.com/fernando-jascovich/
linkedin: https://www.linkedin.com/in/fernandojascovich/





  parent reply	other threads:[~2019-01-08 22:11 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27 10:13 bug#33887: 26.1; Emacs hangs for several seconds when going to the end of an XML file in nXML mode Vincent Lefevre
2018-12-27 16:02 ` Eli Zaretskii
2018-12-27 16:39   ` Stefan Monnier
2018-12-27 16:43     ` Eli Zaretskii
2018-12-27 17:32       ` Stefan Monnier
2018-12-27 17:47         ` Eli Zaretskii
2018-12-27 18:43         ` Vincent Lefevre
2018-12-28 17:18           ` Stefan Monnier
2019-01-17 22:57   ` Stefan Monnier
2019-01-08 22:11 ` Fernando Jascovich [this message]
2019-01-10 15:09   ` Eli Zaretskii
2019-01-17 23:25     ` Stefan Monnier
2019-05-15 23:53 ` Noam Postavsky
2019-05-16 10:54   ` Vincent Lefevre
2019-05-16 12:15   ` Noam Postavsky
2019-05-17 21:36     ` Vincent Lefevre
2019-05-18  4:15       ` Noam Postavsky
2019-05-18 14:47         ` Vincent Lefevre
2019-05-18 14:55           ` Vincent Lefevre
2019-05-18 14:57             ` Vincent Lefevre
2019-05-18 15:01               ` Vincent Lefevre
2019-05-18 18:49           ` Noam Postavsky
2019-05-19  0:17             ` Vincent Lefevre
2019-05-19 17:43               ` Noam Postavsky
2019-05-19 18:48                 ` Stefan Monnier
2019-05-19 19:03                   ` Noam Postavsky
2019-05-19 19:24                     ` Stefan Monnier
2019-05-20 20:47                       ` Noam Postavsky
2019-05-21  1:06                         ` Vincent Lefevre
2019-05-21 12:27                           ` Noam Postavsky
2019-05-22 13:58                             ` Stefan Monnier
2019-05-22 15:44                               ` Vincent Lefevre
2019-05-22 16:01                                 ` Stefan Monnier
2019-05-22 22:37                         ` Stefan Monnier
2019-05-26 22:17                           ` Noam Postavsky
2019-05-27  9:18                             ` Vincent Lefevre
2019-05-27 12:02                               ` Noam Postavsky
2019-05-29  0:30                                 ` Vincent Lefevre
2019-06-04 12:55                                   ` Noam Postavsky
2019-05-22 21:44                       ` Stefan Monnier
2019-05-20 11:47             ` Vincent Lefevre
2019-05-16 14:01   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef9m2421.fsf@gmail.com \
    --to=fernando.ej@gmail.com \
    --cc=33887@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.