From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.devel Subject: Re: Recent diff-mode changes feel slow with TRAMP Date: Sun, 13 Jan 2019 21:23:26 -0800 Message-ID: <87ef9f6cdt.fsf@dima.secretsauce.net> References: <87r2di5x4r.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547443304 25050 195.159.176.226 (14 Jan 2019 05:21:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2019 05:21:44 +0000 (UTC) User-Agent: mu4e 1.0; emacs 27.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 14 06:21:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giugr-0006LX-E3 for ged-emacs-devel@m.gmane.org; Mon, 14 Jan 2019 06:21:38 +0100 Original-Received: from localhost ([127.0.0.1]:41148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giuiy-0006S2-1e for ged-emacs-devel@m.gmane.org; Mon, 14 Jan 2019 00:23:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giuis-0006Rg-A6 for emacs-devel@gnu.org; Mon, 14 Jan 2019 00:23:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giuiq-0003R9-BK for emacs-devel@gnu.org; Mon, 14 Jan 2019 00:23:42 -0500 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:58081) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1giuio-0003NG-6g for emacs-devel@gnu.org; Mon, 14 Jan 2019 00:23:40 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A86B9146B for ; Mon, 14 Jan 2019 00:23:28 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 00:23:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=references:from:to:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm2; bh=O5cCus8j4V0W6jrpFdwC/c89Sr EOSLx62o0AvO/82+M=; b=m5V7mKTqLwzRL9mUNK8SeDPERmWi3Fo1IabDEY7cBQ l1VeE/0HxzngDFsea37LAnZhIFNKdO7IRUFxUQyhcOvxHz0aSsQ2AKJvWt5/O1fl EeSRRUJMND6tyhYxEtwmeqY7IRrEbTwhQKrp0q4GhPBh+hgZqpmd7Ogk6nr/M/yE g1Gnl4gNRueIuY1QAiuMunq8ehosUJQNOz/jjlga7XCSA9YzHkmRThjI83oKoVi9 jJ4pbFZ3prZOSzls+uut+iDlRg0vYgEVpeNuHzjIDPfM2s1p3/TAAS9wxamTJm6C ZBx12y1AcKGgLFYd7X0VvqwYLDRpgI6wycn0q8HYIy7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=O5cCus 8j4V0W6jrpFdwC/c89SrEOSLx62o0AvO/82+M=; b=Rx3jPA3GRgaUncZ7AkGA9I UzZ0nAj2mBYGaBD4waczYUAMRJuOY7nCzCYHzkxSdAVEGhBTlTNZKuFN1nh7F3lZ PT03SdMKAriM2w7cC0M+sR4ogWyRf+GY3S+sTcRz1sZcYvGkQvYlSMKwi80AukHl zJnol1EK5k9KuS/LqAKNWRaF/FdNBrh4WO6eKmA/ERLqkcKNwoyC3hEGqIbCRGab Yvzd61Tu+OgdmOQwxhwEfeqCHsRdn6rOxQp14obfVrmK7FDw8IvvQe8N1sXTWdkW z1El2Y2oiOXJ5LZ2KcB/bAIXm+5ffzm8PYgm8F4q+/ss9Sf8/B3A2ZrLlJ6Ryi/A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedtgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpehffgfhvffujgffkfggtgesthdtredttdertdenucfhrhhomhepff himhgrucfmohhgrghnuceolhhishhtshesughimhgrrdhsvggtrhgvthhsrghutggvrdhn vghtqeenucffohhmrghinhepshgvtghrvghtshgruhgtvgdrnhgvthenucfkphepuddtje drvddutddrvddufedrvdegfeenucfrrghrrghmpehmrghilhhfrhhomhepughimhgrsehs vggtrhgvthhsrghutggvrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from scrawny (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA id B7D861026D for ; Mon, 14 Jan 2019 00:23:27 -0500 (EST) Original-Received: from dima by scrawny with local (Exim 4.91) (envelope-from ) id 1giuic-0005uF-Kz for emacs-devel@gnu.org; Sun, 13 Jan 2019 21:23:26 -0800 In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232333 Archived-At: Charles A. Roelli writes: > Did you try turning off "diff-font-lock-syntax"? This new feature will > find each file in the diff to provide correct font-locking. Maybe it > should be disabled by default in remote buffers. Gah. I sent the email before I was done. OK. Yes. Setting diff-font-lock-syntax to nil makes it fast again. Thanks a lot for pointing me to that. The docs for diff-font-lock-syntax say that 'hunk-only is the fastest setting here, but that's not true, right? Isn't nil the fastest one? For my use cases, I don't think I want this enabled at all, TRAMP or not. Combined with refinement, this makes the diffs more difficult to interpret, at least to me. And even without TRAMP, this makes it slower. Do we really want both refinement and this font-locking enabled by default? There's also a visual issue with auto-refinement. If I load a patch file with 'emacs -Q -rv' (no user settings, but reverse video), it looks like this: http://notes.secretsauce.net/emacsdiff.png Note that the bright green refined face makes the leading + invisible. There's an identical problem with the bright red making the leading - invisible. Thanks for the work. I'll try to help out more when I get more time. dima