From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: John Shahid Newsgroups: gmane.emacs.devel Subject: Fwd: Re: Feedback on getting rid of `term-suppress-hard-newline' Date: Wed, 27 Feb 2019 07:54:20 -0500 Message-ID: <87ef7t9ytf.fsf@gmail.com> References: <87efanc576.fsf@gmail.com> <87sgxsr8p0.fsf@gmail.com> <871s56sw98.fsf@gmail.com> <87lg3d3g70.fsf@gmail.com> <87lg2512zb.fsf@gmail.com> <87k1ho26vc.fsf@gmail.com> <87h8cr9is1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65264"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 27 14:42:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyzTy-000GpE-WF for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2019 14:42:47 +0100 Original-Received: from localhost ([127.0.0.1]:43936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyzTy-0004zH-01 for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2019 08:42:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyzDp-0002OY-DW for emacs-devel@gnu.org; Wed, 27 Feb 2019 08:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyzDn-0001Cj-14 for emacs-devel@gnu.org; Wed, 27 Feb 2019 08:26:05 -0500 Original-Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]:44561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyzDZ-000148-TV for emacs-devel@gnu.org; Wed, 27 Feb 2019 08:25:56 -0500 Original-Received: by mail-qt1-x82e.google.com with SMTP id d2so19042913qti.11 for ; Wed, 27 Feb 2019 05:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:message-id:mime-version; bh=LGeveW5Eu2Go/A01zT3j6LsEdqgALtzXCy98v3uiQ3U=; b=g5XcOh6OnYJ8PZDPNFUnIKBTypBKCp1noBCTQJRkzSKPyuFBK1FppXkVi86n9BYlpX 7Okkf8WtmihKCCiBk6H85H3Cset6q4fwkuWhNVaHPvyJRBW1K80fTw2zJWsBoDR1cBaY 2F+kOGu4qjmU0DUQAj+qt2JimdmsgMpbYyMMdGh56976aI8Szbe9drGUft+GF0VuIkji 1kfBQCk/LplIOf5fW76cxMtxrR+sfE7Drw1v3bHq9lmgI3JVNpi4m/4GbHmdgryHtzlq YSSbwTRMnphSaJQWe3sY1AJWkjaOF3Df3h9QRR6Qhn34tgyaNYZZwYxzdxSjcANdK9k7 SuvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :message-id:mime-version; bh=LGeveW5Eu2Go/A01zT3j6LsEdqgALtzXCy98v3uiQ3U=; b=THi+CjEHO7GhmdV/bt/8cLym6/LscxT7QHZ8S5xSBvgXeMhjTOTCk/3zpaHyKqei6b G6t6eHouv5PZK0TX5d0+Ckx0q07+5TcyH3SURSg5bD0sm8xbjGuWJK1Y5cu14SeX1VXK RFV23xXMmN1BOh4PvCJ09aQbSqxKs0S2/agsF+hIzQiKgnoq1aTKlfBqUuvjWvDRGBJJ qd7JvBrq2tQMWeVS4hLW9IhN2xUYp8J089nUXmFrenCXT8lCC1bFuFG5h6hOVehWT/Eo WcsaU4IZnirR0gcv+syY2oXN7aTL5DVmM38LYC/+hfBbWYJ2J28IiEfHHA8SsULGOuBg OxwA== X-Gm-Message-State: APjAAAXpBmGyMKzfwwSpVrz3svxm7V6l8SYBXZ4xmRqEXrdJ4S0Ktwki PWtyKmvbXi9lyiSL3/t+H7H82CV5 X-Google-Smtp-Source: APXvYqy0oCWHS+P+UVzW/lX/Be6aKFINR7wcoZFb9ZnLN7J7xWB9X7xbGU43ollTZLgxVAdSPsuMSQ== X-Received: by 2002:a0c:e98f:: with SMTP id z15mr1752200qvn.115.1551272064302; Wed, 27 Feb 2019 04:54:24 -0800 (PST) Original-Received: from amun ([66.226.221.158]) by smtp.gmail.com with ESMTPSA id t55sm10845347qtt.57.2019.02.27.04.54.22 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 04:54:23 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233643 Archived-At: I just realized that my previous email was just to Stefan. Re-sending to emacs-devel. As I mentioned below, I noticed some missing logic when I was wrapping up the final patch that was pushed to master a few days ago. I fixed the problem in the patch attached below. Can someone please push it to master. Thanks, JS John Shahid writes: > Looks like I removed an important piece of logic when I reverted the > removal of `(unless term-suppress-hard-newline...`. The change seemed > innocent enough, that I thought it didn't require testing. > > I added back the required logic in the attached patch. Can you please > install it ? > > Thanks, > > JS > > From d20013c6fdd9d84d216d77135f5ef012f8fb3f06 Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Tue, 26 Feb 2019 01:06:53 -0500 > Subject: [PATCH] Add text properties to newlines used to unwrap long lines. > > * lisp/term.el (term-emulate-terminal): do it. > --- > lisp/term.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/term.el b/lisp/term.el > index e759bb8e4f..693362cc73 100644 > --- a/lisp/term.el > +++ b/lisp/term.el > @@ -2935,6 +2935,7 @@ term-emulate-terminal > (delete-region (point) (line-end-position)) > (term-down 1 t) > (term-move-columns (- (term-current-column))) > + (put-text-property (1- (point)) (point) 'term-line-wrap t) > (setq decoded-substring > (substring decoded-substring (- term-width old-column))) > (setq old-column 0)))