From: John Shahid <jvshahid@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Fwd: Re: Feedback on getting rid of `term-suppress-hard-newline'
Date: Wed, 27 Feb 2019 07:54:20 -0500 [thread overview]
Message-ID: <87ef7t9ytf.fsf@gmail.com> (raw)
In-Reply-To: 87h8cr9is1.fsf@gmail.com
I just realized that my previous email was just to Stefan. Re-sending to
emacs-devel.
As I mentioned below, I noticed some missing logic when I was wrapping
up the final patch that was pushed to master a few days ago. I fixed
the problem in the patch attached below. Can someone please push it to
master.
Thanks,
JS
John Shahid <jvshahid@gmail.com> writes:
> Looks like I removed an important piece of logic when I reverted the
> removal of `(unless term-suppress-hard-newline...`. The change seemed
> innocent enough, that I thought it didn't require testing.
>
> I added back the required logic in the attached patch. Can you please
> install it ?
>
> Thanks,
>
> JS
>
> From d20013c6fdd9d84d216d77135f5ef012f8fb3f06 Mon Sep 17 00:00:00 2001
> From: John Shahid <jvshahid@gmail.com>
> Date: Tue, 26 Feb 2019 01:06:53 -0500
> Subject: [PATCH] Add text properties to newlines used to unwrap long lines.
>
> * lisp/term.el (term-emulate-terminal): do it.
> ---
> lisp/term.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/term.el b/lisp/term.el
> index e759bb8e4f..693362cc73 100644
> --- a/lisp/term.el
> +++ b/lisp/term.el
> @@ -2935,6 +2935,7 @@ term-emulate-terminal
> (delete-region (point) (line-end-position))
> (term-down 1 t)
> (term-move-columns (- (term-current-column)))
> + (put-text-property (1- (point)) (point) 'term-line-wrap t)
> (setq decoded-substring
> (substring decoded-substring (- term-width old-column)))
> (setq old-column 0)))
prev parent reply other threads:[~2019-02-27 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 12:14 Feedback on getting rid of `term-suppress-hard-newline' John Shahid
2019-01-16 14:14 ` John Shahid
2019-01-16 16:51 ` Stefan Monnier
2019-01-21 0:14 ` John Shahid
2019-01-21 3:04 ` Stefan Monnier
2019-01-21 20:32 ` John Shahid
2019-02-20 14:54 ` John Shahid
2019-02-21 14:55 ` Stefan Monnier
2019-02-24 18:00 ` John Shahid
[not found] ` <jwvh8cs6fzt.fsf-monnier+emacs@gnu.org>
[not found] ` <87k1ho26vc.fsf@gmail.com>
[not found] ` <87h8cr9is1.fsf@gmail.com>
2019-02-27 12:54 ` John Shahid [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef7t9ytf.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.