Re: [ELPA] New package: disk-usage

[Michael Albinus <michael.albinus@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Hi Michael,

Hi Pierre,

> I've pushed your suggestions.

Thanks.

> - Regarding the TRAMP issue, I fail to test with "/sudo::", probably because
>   `find/du` cannot run there.  Let me know if it works for you on
> remote machines.

I did need to apply further changes to let it run sufficiently on /sudo::

* In disk-usage--list-recursively, the (concat (file-remote-p ...) trick
  must be applied earlier.

* In disk-usage--list-recursively and disk-usage--list I needed to adapt
  the directory-files-and-attributes call; otherwise also /. and
  /.. would be reported.

If the remote case still doesn't work for you, set tramp-verbose to 6,
and rerun the test. Show the resulting Tramp debug buffer.

> - Regarding the optimization, local tests show no difference.  Let me know if
>   you notice a significant improvement remotely.

I have no figures, but it feels faster.

One other point worth to fix: Pls don't run
disk-usage-toggle-recursive globally. It shall affect only the current
buffer; I don't want to have a recursive disk-usage report for every
remote directory. It takes too much time.

> Cheers!

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 3026 bytes --]

*** /tmp/ediffhiunfK	2019-03-03 11:26:50.677462619 +0100
--- /home/albinus/src/elpa/packages/disk-usage/disk-usage.el	2019-03-03 10:59:27.620803344 +0100
***************
*** 263,269 ****
                       (and (file-accessible-directory-p directory)
                            (directory-files-and-attributes
                             directory
!                            'full nil 'nosort)))))
      (or (cl-loop for l in listing
                   for attributes = (cl-rest l)
                   for path = (cl-first l)
--- 263,270 ----
                       (and (file-accessible-directory-p directory)
                            (directory-files-and-attributes
                             directory
!                            'full directory-files-no-dot-files-regexp
! 			   'nosort)))))
      (or (cl-loop for l in listing
                   for attributes = (cl-rest l)
                   for path = (cl-first l)
***************
*** 280,288 ****
                            :name path
                            :size (file-attribute-size attributes))
                   ;; Folders
!                  else if (and (eq t (file-attribute-type attributes))
!                               (not (string= "." (file-name-base path)))
!                               (not (string= ".." (file-name-base path))))
                   collect
                   (disk-usage--file-info-make
                    :name path
--- 281,287 ----
                            :name path
                            :size (file-attribute-size attributes))
                   ;; Folders
!                  else if (eq t (file-attribute-type attributes))
                   collect
                   (disk-usage--file-info-make
                    :name path
***************
*** 305,313 ****
                                          "-type" "d")
                            (buffer-string))
                          "\n" 'omit-nulls)))
!     (cl-loop for dir in subdirs
!              append (cl-loop for file in (directory-files-and-attributes dir 'full nil 'nosort)
!                              for name = (concat (file-remote-p directory) (car file))
                               for attributes = (cdr file)
                               when (and attributes
                                         (not (file-attribute-type attributes))
--- 304,317 ----
                                          "-type" "d")
                            (buffer-string))
                          "\n" 'omit-nulls)))
!     (cl-loop for dir in (mapcar (lambda (item)
! 				  (concat (file-remote-p directory) item))
! 				subdirs)
!              append (cl-loop for file in (directory-files-and-attributes
! 					  dir 'full
! 					  directory-files-no-dot-files-regexp
! 					  'nosort)
!                              for name = (car file)
                               for attributes = (cdr file)
                               when (and attributes
                                         (not (file-attribute-type attributes))