From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35287@debbugs.gnu.org, "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: bug#35287: dired-do-copy English beef-up
Date: Wed, 24 Apr 2019 23:15:13 +0300 [thread overview]
Message-ID: <87ef5r6vta.fsf@mail.linkov.net> (raw)
In-Reply-To: <b6599c31-76cc-4da7-bcca-f2cdd256f16e@default> (Drew Adams's message of "Thu, 18 Apr 2019 14:10:56 -0700 (PDT)")
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
>> Then a complete set of messages:
>>
>> Copy: 3 files done
>> Copy: 2 of 3 files skipped
>> Copy: 2 of 3 files failed
>> Copy: 2 files in 3 requests failed
>
> What is the difference between the last two?
The latter is used for recursive operations.
> What about the current existing messages when
> there are failures, telling you to use `?' to
> see the details (the `dired-log' output)?
This is now unified as well:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired-aux.i18n.patch --]
[-- Type: text/x-diff, Size: 1903 bytes --]
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index b81c0d1a4f..e967f94e06 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1798,32 +1798,36 @@ dired-create-files
(progn
(push (dired-make-relative from)
failures)
- (dired-log "%s `%s' to `%s' failed:\n%s\n"
+ (dired-log "%s: `%s' to `%s' failed:\n%s\n"
operation from to err))))))))
(cond
(dired-create-files-failures
(setq failures (nconc failures dired-create-files-failures))
(dired-log-summary
- (format "%s failed for %d file%s in %d requests"
- operation (length failures)
- (dired-plural-s (length failures))
- total)
+ (format (ngettext "%s failed for %d file in %d requests"
+ "%s failed for %d files in %d requests"
+ (length failures))
+ operation (length failures) total)
failures))
(failures
(dired-log-summary
- (format "%s failed for %d of %d file%s"
- operation (length failures)
- total (dired-plural-s total))
+ (format (ngettext "%s: %d of %d file failed"
+ "%s: %d of %d files failed"
+ total)
+ operation (length failures) total)
failures))
(skipped
(dired-log-summary
- (format "%s: %d of %d file%s skipped"
- operation (length skipped) total
- (dired-plural-s total))
+ (format (ngettext "%s: %d of %d file skipped"
+ "%s: %d of %d files skipped"
+ total)
+ operation (length skipped) total)
skipped))
(t
- (message "%s: %s file%s"
- operation success-count (dired-plural-s success-count)))))
+ (message (ngettext "%s: %d file done"
+ "%s: %d files done"
+ success-count)
+ operation success-count))))
(dired-move-to-filename))
\f
(defun dired-do-create-files (op-symbol file-creator operation arg
next prev parent reply other threads:[~2019-04-24 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 11:49 bug#35287: dired-do-copy English beef-up 積丹尼 Dan Jacobson
2019-04-16 20:35 ` Juri Linkov
2019-04-16 21:57 ` Drew Adams
2019-04-17 19:04 ` 積丹尼 Dan Jacobson
2019-04-17 19:58 ` Juri Linkov
2019-04-17 22:53 ` Drew Adams
2019-04-18 10:28 ` 積丹尼 Dan Jacobson
2019-04-18 20:59 ` Juri Linkov
2019-04-18 21:10 ` Drew Adams
2019-04-19 2:08 ` 積丹尼 Dan Jacobson
2019-04-19 4:33 ` Drew Adams
2019-04-19 13:48 ` 積丹尼 Dan Jacobson
2019-04-19 14:28 ` Drew Adams
2019-04-19 15:03 ` Eli Zaretskii
2019-04-19 15:11 ` Drew Adams
2019-04-19 15:14 ` 積丹尼 Dan Jacobson
2019-04-24 20:15 ` Juri Linkov [this message]
2019-05-05 19:43 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef5r6vta.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=35287@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.