From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 29 Apr 2019 14:26:09 +0200 Message-ID: <87ef5lxaji.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="34320"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 14:27:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL5NK-0008ny-3g for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 14:27:14 +0200 Original-Received: from localhost ([127.0.0.1]:56961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL5NJ-0001XX-3w for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 08:27:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL5NB-0001Wb-CI for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL5N9-0005En-0y for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL5N8-0005Dv-28 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hL5N7-00011o-T0 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 08:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15565407913915 (code B ref 35418); Mon, 29 Apr 2019 12:27:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 12:26:31 +0000 Original-Received: from localhost ([127.0.0.1]:38576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Md-000115-2C for submit@debbugs.gnu.org; Mon, 29 Apr 2019 08:26:31 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:40197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL5Mb-00010r-Fo for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 08:26:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556540771; bh=jNe+zK5s2hcgj3kuXX8Sur9FnQX7KHYDquhHNqIcTbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Ix/18CCOoRMgvJmUVn/fMiVkqDiXzBApB5z2bvCtk/q9+XsEiFY8z/t6D8s3I5mr5 6jHHUea4zMpGhyEUVEGA0OSbEQVWfhXRPwfb4UBvi0UNQ6htdgYS8zyL24l5qJonf9 h5b6lvTJxJWs/yEB/4WlbssW7XDmtIHde0Alu06A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.159.69]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Le69A-1h01Hj2Dls-00pxxa; Mon, 29 Apr 2019 14:26:11 +0200 In-Reply-To: <093C7A57-E3EA-446D-B283-07328850094A@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 29 Apr 2019 13:54:48 +0200") X-Provags-ID: V03:K1:913XtnQXPvU6YG23aNz+lSw/+DE+6AACLS5IRVqGxsEsMqX54s0 BK6lMlgRzvw57gVrEjkMpGrSIdIcBA2voIPIq4SsPBNZzoFNo5++NaGfBAr3IAN3buDXqgB J/zQhDqnazDjPDPcuWLEBHImBNURQa91Vcg9e8xZaUWvwluaWvMt50LS4ANE8NHOYlA3xxh OpRBfchAtEe2HB4DuF4iA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Opv+nc2AZfE=:kYvdGrBVL71K8yqqXAsm/L PAHIBViLiCAGNOd1Bmm054YzulfewVvxgqe1CH50CkLG/R6d4JGDUjdoJIRIiegSQHFdBGeZO 6eW34Oa11Qa0V0foeVjvo5XjkikbmNWfA/RShsw74C15+NlKP35IT0UDi5iRjwzuCm/lVBu57 tNJ6hbsSKuiXrk5070WrldktnhI4MFsvmKHTk0FSatFK5Cu4fJ+vwwDMF5bguMFP7At9AQV3C a1JcbAFdJq6fL+I7P7NmDpBdaGmDyXp99wb1z06AkKc0bIFRx6wWMzf/r/8r7ORTVJf1BnVhH dIE36+o3qrhvUnC2AZI9loXU4m5jIhKcZUe1py7rMMo1TEwaGfhvbIkILW3NMxuNelC/tGpEu sXXYPJVnrkdH4jaFAhiXPxVKz8i1u8hYjEpqq46Dk4P8azVxLL6zES+a6kyzxiIY2Fuix8EkU 0B9y0wR32Gw1K6rw8UyfIUyknahj3t+OEQaoSF59/10Uy1F79cLLCwI8UtHEE10fU57hMw0kW esEBJ/YEwakAdi7NUpjSIYym+0kcISHdHFIclHiy0nOexCv1I5Qdnle6QPprdfCh6xaqtJUh9 cgYAN5IP+rxov1J0Z4OTDhTT3xraOT/rjibfB1woGUXmj5tLl98T0qdHFeDgnt61Ifw2nITDd ARo8e+AvQtzGc393rkq++Hx5tgbguvQ9ReSmmLkptdSv29Ll9GqguCqMcWw49GHG0sjRfzL0Y b4m2dQNwjB6oz3B1eB7YdUNHQTgQqD3eEw6aBj6vKJN9fJWdLLAahSlhpZuUhoMRDsg2q4+e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158424 Archived-At: Mattias Engdeg=C3=A5rd writes: >> By design, in filenotify.el, we want see only events which are related >> to the file *name*. If you want to be notified for both buffers, you >> need to watch both file (names). > > Well yes, but you want a change to the file to be reported for both > buffers, even if they watch different names, right? You don't know first hand, which buffers contain the same file hard linked together. This can be determined only via the inode and device numbers; something we don't apply yet. How do you know otherwise, that "/tmp/foo" and "/tmp/bar" are the same, visited in different buffers? > Otherwise, it wouldn't make sense at all. If someone is watching a > file, surely it is because changes to the contents of that file are of > interest? Why would the name employed to carry out the changes matter? That's a desirable feature, I agree. But we haven't implemented it yet. Likely, we shall say so in the doc. > I'm quite sure there is a simple misunderstanding here; probably my > fault. And again, I don't think it matters much in practice since > users are unlikely to have buffers for different hard links to the > same file. Let's not waste too much time on this. Agreed. I won't change something in this respect, until there is a bug report / feature request. And as said, maybe you could add a sentence about in the manual. > Thank you. Most of those cases should not cause any trouble -- except > unreliable file notification processes, but since > `auto-revert-remote-files' defaults to nil, it didn't look like a > serious problem. As Tramp maintainer, I always set `auto-revert-remote-files' to t :-) So I care. Best regards, Michael.