From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Thu, 02 May 2019 12:14:10 -0600 Message-ID: <87ef5gn2q5.fsf@gmail.com> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> <20190430201129.GA73973@breton.holly.idiocy.org> <837ebaqdme.fsf@gnu.org> <20190501210847.GA74837@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193027"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35468@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 02 20:15:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMGEh-000o4U-VZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 20:15:12 +0200 Original-Received: from localhost ([127.0.0.1]:56895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMGEg-0002yv-UI for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 14:15:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMGEa-0002yn-UZ for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 14:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMGEZ-0000yz-0U for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 14:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33431) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMGEY-0000yV-63 for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 14:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMGEX-0002PZ-TZ for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 14:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Gramiak Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 18:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.15568208599205 (code B ref 35468); Thu, 02 May 2019 18:15:01 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 2 May 2019 18:14:19 +0000 Original-Received: from localhost ([127.0.0.1]:46975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMGDr-0002OP-3E for submit@debbugs.gnu.org; Thu, 02 May 2019 14:14:19 -0400 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:43221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMGDp-0002OD-Ej for 35468@debbugs.gnu.org; Thu, 02 May 2019 14:14:18 -0400 Original-Received: by mail-pl1-f178.google.com with SMTP id n8so1386717plp.10 for <35468@debbugs.gnu.org>; Thu, 02 May 2019 11:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=vzTfdR+Ij1EbAkMAMUuoqhx7RdaIBCB6gtuihRGd2kI=; b=nxYNAv9IyJB43Ku5qSUmhU5Iq6ThIE3SMry7mBd6VxJENvEghDHeZwHoBMrVPCjoXn o/1kSsmjLZKxL7ZuECojt6I1TFJ4DtjTg9aZZOGMVXGVejvUnR6edfwEzDedg5B/mA+T qjutNbug9h/c/FZnV4m4nIvRmDnJI3qJJxAQlpTJej0SnrlU2c20952neU9Gw2Dk1bCS Iy3q5/1EULV0DIJvcNG6bXS+/Vr6JMSmyUYYuez1zbmDa852EUTWPkkuFVuHERT5UBMA EyLsMDmD19Qu7hSv+qP5RKD742V2hBsABNTZlHSg9nq9GZz41jjFy7at4VYhsSgf9TG0 O3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=vzTfdR+Ij1EbAkMAMUuoqhx7RdaIBCB6gtuihRGd2kI=; b=L9mJcc7FvDHyMqOKPEk1sj95y2ZyyglCjKVlmj8DdfrCiXtEbovyQBsM6babc99Frl 2Hp8Fah8mM7pQbqBLsaQ2mW6nSFIQpdXDeZnmhvS+LZtCl9OGQI2DOyV7JW0c9enAMbE NV1VvaH0a0qDMN5Hkl5uB7pPsfcQ9l4/ygEGD2JjOcOS5AsFvo8RXDkjBEXKtWKyc8ts 82GhZe8PaC3BGV9E7SNbX1ZPc2nuDSBSKp+z8KxCfme+0n/SUteAWuWr22bz5dCfI37k 0bEA1FdJcMqqdu9/QzJnpjW+UoobOaFdi+RsfXOl4nrT2g9u1sOD1arRIkg+dbRuscn7 74Jg== X-Gm-Message-State: APjAAAVoAQ+jml/142OXXEntNn/BNCTvzrxwNtqGXi7B7V+6jt1QJgy8 6hgDSKrcnFGQ0DizyHuECX5yxgLP X-Google-Smtp-Source: APXvYqxi0vZeEcfoK38l+ZqfbnI6oljJCckMSvmFttqZw1ylm1XL+l5yNtpq3CRIfs7O9yPBCJNGzg== X-Received: by 2002:a17:902:7b97:: with SMTP id w23mr5313734pll.335.1556820851096; Thu, 02 May 2019 11:14:11 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id a18sm4918990pff.6.2019.05.02.11.14.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 11:14:09 -0700 (PDT) In-Reply-To: <20190501210847.GA74837@breton.holly.idiocy.org> (Alan Third's message of "Wed, 1 May 2019 22:08:47 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158658 Archived-At: Alan Third writes: > It looks exactly the same to me with or without the code. Perhaps I=E2=80= =99d > see something different if I was using some theme which defined mouse > face differently. > > I really don=E2=80=99t see any reason why NS should behave differently fr= om > the other terms here. There's a similar block in ns_maybe_dumpglyphs_background. Could you test with that block removed as well? Also, there's a conditional check (s->hl !=3D DRAW_CURSOR) there that's not present in the other versions; could you see if that's necessary?