From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Thu, 01 Aug 2019 13:11:24 +0200 Message-ID: <87ef25nns3.fsf__15281.3320093387$1564657942$gmane$org@mouse.gnus.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <87v9vinefd.fsf@mouse.gnus.org> <877e7xjxjj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="15535"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 01 13:12:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht90K-0003v0-JS for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 13:12:16 +0200 Original-Received: from localhost ([::1]:54634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht90J-0006dL-JM for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 07:12:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57748) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht90B-0006Z6-OM for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 07:12:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ht908-0007HQ-1V for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 07:12:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ht906-0007F3-Ds for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 07:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ht906-0005tT-87 for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 07:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Aug 2019 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34160-submit@debbugs.gnu.org id=B34160.156465789022619 (code B ref 34160); Thu, 01 Aug 2019 11:12:02 +0000 Original-Received: (at 34160) by debbugs.gnu.org; 1 Aug 2019 11:11:30 +0000 Original-Received: from localhost ([127.0.0.1]:53559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ht8zZ-0005sk-TB for submit@debbugs.gnu.org; Thu, 01 Aug 2019 07:11:30 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:38026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ht8zY-0005sd-Uu for 34160@debbugs.gnu.org; Thu, 01 Aug 2019 07:11:29 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht8zV-0006EY-MJ; Thu, 01 Aug 2019 13:11:28 +0200 In-Reply-To: <877e7xjxjj.fsf@gnu.org> (Tassilo Horn's message of "Thu, 01 Aug 2019 06:54:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164211 Archived-At: Tassilo Horn writes: > It can still be a bit improved in understandability and efficiency. > > 1. The function passed to replace-region-contents runs on the narrowed > buffer anyway, so no need to narrow it yourself. > > 2. It would be better to create a temporary buffer, json-read repeatedly > from the original buffer, json-encode/insert to the temp one, and > then return the temp buffer. > > The reason for point 2 is that if the function passed to > replace-region-contents returns a string, it'll put that in a temporary > buffer anyhow so that it can use replace-buffer-contents to perform the > actual replacement (replace-region-contents is just a wrapper around > that). Sounds like a good idea; please go ahead. > And we might want to cater for the situation where the region starts or > ends inside a json object by copying the buffer substring from (point) > to end to the temp buffer in case json-read fails. I think right now, > we'd lose such half json objects and everything which follows them. Yes, that sounds like a good fix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no