From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Thu, 01 Aug 2019 13:11:24 +0200 Message-ID: <87ef25nns3.fsf@mouse.gnus.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <87v9vinefd.fsf@mouse.gnus.org> <877e7xjxjj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13084"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 13:11:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht8zg-0003Gw-Iw for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 13:11:36 +0200 Original-Received: from localhost ([::1]:54630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht8zf-00064f-9i for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 07:11:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57587) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ht8za-00062J-K5 for emacs-devel@gnu.org; Thu, 01 Aug 2019 07:11:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ht8zZ-0005me-JI for emacs-devel@gnu.org; Thu, 01 Aug 2019 07:11:30 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:60678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ht8zZ-0005mI-DA; Thu, 01 Aug 2019 07:11:29 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ht8zV-0006EY-MJ; Thu, 01 Aug 2019 13:11:28 +0200 In-Reply-To: <877e7xjxjj.fsf@gnu.org> (Tassilo Horn's message of "Thu, 01 Aug 2019 06:54:08 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239088 Archived-At: Tassilo Horn writes: > It can still be a bit improved in understandability and efficiency. > > 1. The function passed to replace-region-contents runs on the narrowed > buffer anyway, so no need to narrow it yourself. > > 2. It would be better to create a temporary buffer, json-read repeatedly > from the original buffer, json-encode/insert to the temp one, and > then return the temp buffer. > > The reason for point 2 is that if the function passed to > replace-region-contents returns a string, it'll put that in a temporary > buffer anyhow so that it can use replace-buffer-contents to perform the > actual replacement (replace-region-contents is just a wrapper around > that). Sounds like a good idea; please go ahead. > And we might want to cater for the situation where the region starts or > ends inside a json object by copying the buffer substring from (point) > to end to the temp buffer in case json-read fails. I think right now, > we'd lose such half json objects and everything which follows them. Yes, that sounds like a good fix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no