From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#19892: 25.0.50; hideshow: hs-hide-all-non-comment-function example infloop Date: Fri, 02 Aug 2019 21:08:54 +0200 Message-ID: <87ef23o055.fsf@mouse.gnus.org> References: <87r3tonon8.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60836"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: ttn@gnu.org, dann@ics.uci.edu, 19892@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 02 21:10:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcwY-000Fgf-Bm for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 21:10:22 +0200 Original-Received: from localhost ([::1]:37072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcwW-0007gr-T4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 15:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43709) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcwK-0007gX-FC for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:10:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htcwE-0008Hm-N8 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htcwD-0008GS-RN for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htcwD-0007FH-KP for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 15:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2019 19:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19892 X-GNU-PR-Package: emacs Original-Received: via spool by 19892-submit@debbugs.gnu.org id=B19892.156477294627769 (code B ref 19892); Fri, 02 Aug 2019 19:10:01 +0000 Original-Received: (at 19892) by debbugs.gnu.org; 2 Aug 2019 19:09:06 +0000 Original-Received: from localhost ([127.0.0.1]:57724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htcvK-0007Dp-59 for submit@debbugs.gnu.org; Fri, 02 Aug 2019 15:09:06 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:34368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htcvI-0007Dh-DJ for 19892@debbugs.gnu.org; Fri, 02 Aug 2019 15:09:04 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcv8-00054L-Ul; Fri, 02 Aug 2019 21:08:57 +0200 In-Reply-To: <87r3tonon8.fsf@web.de> (Michael Heerdegen's message of "Tue, 17 Feb 2015 23:45:15 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164380 Archived-At: Michael Heerdegen writes: > in the header of hideshow.el, we have the following paragraph: [...] > ;; (defun ttn-hs-hide-level-1 () > ;; (hs-hide-level 1) > ;; (forward-sexp 1)) > ;; (setq hs-hide-all-non-comment-function 'ttn-hs-hide-level-1) > > But this doesn't always work. For example, eval the above example in > emacs -Q, open "files.el", M-x hs-minor-mode, M-x hs-hide-all. You get > an infloop. > > AFAICT the definition should be (or at least it works with that) > > (defun ttn-hs-hide-level-1 () > (when (hs-looking-at-block-start-p) > (hs-hide-level 1)) > (forward-sexp 1)) I've confirmed that the example still infloops in Emacs 27, and that your example doesn't, so I've committed it to the Emacs trunk. > Secondly, there is this comment in `hs-hide-all' which confuses me a bit: > > ;; Go to end of matched data to prevent from getting stuck > ;; with an endless loop. > > Which match data is meant there? It is either match data from before > hiding the block - then it should be documented that > `hs-hide-all-non-comment-function' must not change match data, I guess, > or the call should be wrapped into `save-match-data'. Or it is even the > case that `hs-hide-all-non-comment-function' must set the match data > (how?), which then should probably be documented. Here's the code: (progn (goto-char (match-beginning 1)) (unless (if hs-hide-all-non-comment-function (funcall hs-hide-all-non-comment-function) (hs-hide-block-at-point t)) ;; Go to end of matched data to prevent from getting stuck ;; with an endless loop. (goto-char (match-end 0)))) `hs-hide-block-at-point' calls a lot of functions that change match data, so presumably `hs-hide-all-non-comment-function' is allowed, too. But this all seems nonsensical -- what `match-end' points to here seems pretty random. So it looks like a bug to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no