From: "Štěpán Němec" <stepnem@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
17871@debbugs.gnu.org
Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function?
Date: Sun, 18 Aug 2019 15:32:43 +0200 [thread overview]
Message-ID: <87ef1i38g4.fsf@gmail.com> (raw)
In-Reply-To: <8736hy1wxt.fsf@web.de> (Michael Heerdegen's message of "Sun, 18 Aug 2019 14:26:38 +0200")
On Sun, 18 Aug 2019 14:26:38 +0200
Michael Heerdegen wrote:
>> > (2) Enhance a command to accept an additional argument. The interactive
>> > form of the :around advice will reuse the interactive form of the
>> > original command to read in the arguments the original command accepts,
>> > read in the additional argument, and return the combined list.
>>
>> I think an example along these lines would be very nice for the manual.
>
> Štěpán, any nice idea which command I could use to write the example?
Well, the closest I see in my init is this (in fact I have been doing it
differently and more uglily, but now I see this is simpler):
(defun my-compose-mail-advice (orig &rest args)
"Read From: address interactively."
(interactive (lambda (spec)
(let* ((user-mail-address
(completing-read "From: " '("one.address@example.net"
"alternative.address@example.net")))
(from (message-make-from user-full-name
user-mail-address))
(spec (advice-eval-interactive-spec spec)))
;; notmuch doesn't understand "From", it has to be a symbol
(push (cons 'From from) (nth 2 spec))
spec)))
(apply orig args))
(advice-add 'compose-mail :around #'my-compose-mail-advice)
One might argue that, given the simple nature of `compose-mail' original
interactive spec (no actual user interaction), constructing a plain list
disregarding the original would suffice here, but it would really be
almost the same.
I'm sure one could come up with better examples, but I can't think of
anything off the top of my head.
--
Štěpán
next prev parent reply other threads:[~2019-08-18 13:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 14:13 bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Drew Adams
2014-06-29 15:01 ` Michael Heerdegen
2014-06-29 15:52 ` Drew Adams
2014-06-29 22:03 ` Stefan Monnier
2014-06-29 23:49 ` Drew Adams
2014-06-30 20:48 ` Michael Heerdegen
2019-08-04 12:06 ` Lars Ingebrigtsen
2019-08-04 12:45 ` Michael Heerdegen
2019-08-04 12:56 ` Lars Ingebrigtsen
2019-08-04 15:15 ` Štěpán Němec
2019-08-05 6:26 ` Michael Heerdegen
2019-08-05 8:44 ` Štěpán Němec
2019-08-05 9:21 ` Lars Ingebrigtsen
2019-08-18 12:26 ` Michael Heerdegen
2019-08-18 13:32 ` Štěpán Němec [this message]
2019-08-18 23:06 ` Lars Ingebrigtsen
2019-08-18 23:50 ` Štěpán Němec
2019-08-19 0:35 ` Drew Adams
2019-08-20 21:49 ` Juri Linkov
2019-08-20 22:44 ` Štěpán Němec
2019-08-21 7:01 ` Stefan Monnier
2019-08-21 8:17 ` Štěpán Němec
2019-08-25 15:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef1i38g4.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=17871@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.