From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37214: [PATCH] vc-svn error messages are used as ignore list Date: Sun, 15 Sep 2019 15:16:16 +0200 Message-ID: <87ef0hwvhb.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="56374"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37214@debbugs.gnu.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 15 15:17:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9UOy-000EYT-Jr for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 15:17:16 +0200 Original-Received: from localhost ([::1]:54634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9UOx-0006jI-FQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 09:17:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56015) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9UOm-0006e5-6J for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:17:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9UOl-0000SC-4m for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:17:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9UOk-0000RA-7t for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9UOk-0006Z8-0M for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2019 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37214 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37214-submit@debbugs.gnu.org id=B37214.156855338223234 (code B ref 37214); Sun, 15 Sep 2019 13:17:01 +0000 Original-Received: (at 37214) by debbugs.gnu.org; 15 Sep 2019 13:16:22 +0000 Original-Received: from localhost ([127.0.0.1]:47511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UO5-00062K-HM for submit@debbugs.gnu.org; Sun, 15 Sep 2019 09:16:21 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UO3-00060Q-Kc for 37214@debbugs.gnu.org; Sun, 15 Sep 2019 09:16:19 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9UO0-0000RM-L2; Sun, 15 Sep 2019 15:16:18 +0200 In-Reply-To: (Wolfgang Scherer's message of "Wed, 28 Aug 2019 21:06:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166496 Archived-At: Wolfgang Scherer writes: > * lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer > contents, if exit status is not 0. Split buffer by lines. I don't use svn, but: [...] > - (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) > - (split-string (buffer-string)))) > + (if (= (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) 0) > + (split-string (buffer-string) "\n")))) This looked "obviously correct", so I've applied it without testing (after a slight stylistic change). If this leads to errors with actual svn users, please revert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no