all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
Cc: 37214@debbugs.gnu.org
Subject: bug#37214: [PATCH] vc-svn error messages are used as ignore list
Date: Sun, 15 Sep 2019 15:16:16 +0200	[thread overview]
Message-ID: <87ef0hwvhb.fsf@gnus.org> (raw)
In-Reply-To: <c5c548ef-0c74-4dc2-72ae-b9c068efa852@gmx.de> (Wolfgang Scherer's message of "Wed, 28 Aug 2019 21:06:13 +0200")

Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:

> * lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer
> contents, if exit status is not 0.  Split buffer by lines.

I don't use svn, but:


[...]

> -    (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory))
> -    (split-string (buffer-string))))
> +    (if (= (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) 0)
> +        (split-string (buffer-string) "\n"))))

This looked "obviously correct", so I've applied it without testing
(after a slight stylistic change).  If this leads to errors with actual
svn users, please revert.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-09-15 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 18:54 bug#37214: [PATCH] vc-svn error messages are used as ignore list Wolfgang Scherer
     [not found] ` <handler.37214.B.156701847419761.ack@debbugs.gnu.org>
2019-08-28 19:06   ` Wolfgang Scherer
2019-09-15 13:16     ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef0hwvhb.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=37214@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.