From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9516: imagemagick-register-types and image-file-name-extensions Date: Wed, 25 Sep 2019 14:30:59 +0200 Message-ID: <87ef04woak.fsf@gnus.org> References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> <874o00d8de.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204162"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 9516@debbugs.gnu.org, Chong Yidong To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 25 14:34:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iD6Ut-000r0G-3x for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2019 14:34:19 +0200 Original-Received: from localhost ([::1]:49392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD6Ur-0002Cd-CK for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2019 08:34:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55705) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD6Sh-0001Dp-6l for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 08:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD6Sg-0004eD-64 for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 08:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iD6Sg-0004e6-3Y for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 08:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iD6Sf-0008LT-Ug for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 08:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2019 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9516 X-GNU-PR-Package: emacs Original-Received: via spool by 9516-submit@debbugs.gnu.org id=B9516.156941466629327 (code B ref 9516); Wed, 25 Sep 2019 12:32:01 +0000 Original-Received: (at 9516) by debbugs.gnu.org; 25 Sep 2019 12:31:06 +0000 Original-Received: from localhost ([127.0.0.1]:40954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iD6Rl-0007cf-SB for submit@debbugs.gnu.org; Wed, 25 Sep 2019 08:31:06 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iD6Rk-0007b8-GT for 9516@debbugs.gnu.org; Wed, 25 Sep 2019 08:31:04 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iD6Rg-0002B9-4O; Wed, 25 Sep 2019 14:31:02 +0200 In-Reply-To: <874o00d8de.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 25 Sep 2011 17:03:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167152 Archived-At: Juri Linkov writes: > Then we could change the function `image-file-name-regexp' > that dynamically constructs a composite regexp from > `image-file-name-extensions' and `image-file-name-regexps'. > What we could do is to add to its return value a regexp added > in `imagemagick-register-types' to `image-type-file-name-regexps' > with the assoc value `imagemagick': [...] > + (mapconcat > + 'identity > + (delq nil (list exts-regexp > + image-file-name-regexps > + (car (rassq 'imagemagick image-type-file-name-regexps)))) > + "\\|"))) > > This is a temporary solution for the next release of 24.1 that > will allow image-dired.el to display Imagemagick supported images. > > I think in 24.2, defcustoms in image-file.el should be deprecated > and packages should use `image-type-file-name-regexps' instead. This was seven years ago, but the patch wasn't applied. I know that ImageMagick is slightly semi-deprecated now, but I think this patch possibly makes sense anyway. I don't use the Dired thumbnail stuff, though. Did anybody have an objection to this that didn't land in the bug tracker? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no