From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: master 270ca8c: Fix internal-lisp-face-attributes to match face. Date: Sun, 20 Oct 2019 17:44:06 +0200 Message-ID: <87eez7toah.fsf@gmx.net> References: <20191020144609.32634.23000@vcs0.savannah.gnu.org> <20191020144611.3484F20BBC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="221926"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Jimmy Aguilar Mena To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 20 17:49:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMDSL-000vW8-55 for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 17:49:21 +0200 Original-Received: from localhost ([::1]:38786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDSE-000616-59 for ged-emacs-devel@m.gmane.org; Sun, 20 Oct 2019 11:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57693) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDNQ-0005yR-4E for emacs-devel@gnu.org; Sun, 20 Oct 2019 11:44:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMDNO-0005Dy-W0 for emacs-devel@gnu.org; Sun, 20 Oct 2019 11:44:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:34003) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMDNO-0005DR-IQ for emacs-devel@gnu.org; Sun, 20 Oct 2019 11:44:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571586248; bh=TwB6lzJKzGnE7mwJbX9MgMa4wD+ydUJYtXvsTwOK5Wo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IEfSTRjAmDT0NYG+6CCfMgDClAcNKDh8qO6izXMOtvYCpt17Zihd7XrUd0/xTvOaZ Pa8xzWa2Re3jztfzaltEwK5FUpiLRJcbYsKKqVXPE35Y8ma1EuL8js7uL9YLfw4N38 yxJs7wwDltZydA0PBQaBiDX+Z0TjmsJHPGkI8i+Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-lfs84 ([188.109.159.139]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqb1c-1hiWz2132m-00mYfu; Sun, 20 Oct 2019 17:44:08 +0200 In-Reply-To: <20191020144611.3484F20BBC@vcs0.savannah.gnu.org> (Jimmy Aguilar Mena's message of "Sun, 20 Oct 2019 10:46:10 -0400 (EDT)") X-Provags-ID: V03:K1:sRtb1om3F0w9G93KdYNBQFB9dw8DQHei2IqKZBhLMB8mImIJzqH DX5yUsCCYeWmuS2D7ZcrzkQPQQ1nrwky3h46Whl+rQ6pPptL2JMc9lsCaMe3HbtIesd+5rA QyF8bO3bPZM+RG38BcVJhDG9+YVzxMH218TPoc9pC2J/tGq+j0av6ne+uR7Ldm+oM+F0WZf AghHM8lYfSAuYJTXLee7g== X-UI-Out-Filterresults: notjunk:1;V03:K0:tMJdJzcAQ2I=:lgbO93xe1gF6uovM7ePv1z yefwsrMEOvUaFuEeZe9hBAd8LEabefSk6+1ZzavDQct1co/5S85E6POlIfZ+ZcysN8LUhchSH xGS493fLmZmVOOc+K+Z41PoT/6JnMkJ5A1xYFr2fxCG1UWiDhWrcHIv9cPKq/u4pTvjAE1hd+ uURDZunVwS7rrc/RS+0Yow7IobJUaiPk5KaYFb7VwHlf2P/6spfCPmJD+Uh8/oOnFJPlq4Pfr IJdNSGVCQYc06NgB/L1C66zRBXCf0s6zJ8vgoeDfMtxGIBoRjkfHEXZazYnHYcJS68YH+cvhF B6Vy9IMqICgTOGG5WTcYt/7hSMz3cAeEl3BQ8YV4U8w4KIKTSECEfO0PEwmJjycL0JY7UvtAu +d53SzmoLZjghAawKBdNgRZtg3mZoiuQg6UlDs3KHSnQ8JkTPlJx4lkXxe0Hgxe0+6H1hQxT9 gODQu0xMKiEPvoPDDPI6idNMR2hgYStBlSfukBrAW8t0iE1EYSfzawYkbaNl6/cbijdKdPZ7e 2q71Q+KVb3B+cVujmt9FtG7uzyITqr42rn4eKF6zBGjBYjJ323Am3fP6GQE9/SRfBOeIvenww vrx4MbAAzo9ixwPyHmaxpTEDQwTDqfGQUKkrUyvMKLhUo+41mF77UXBxhtgC0G/EmJs2HIbiv I0u/l+ZGklJn7FTisnwUHd+LvVpOPRHcOLEsVZ4HZYxnAvSBdcqerN14WylIFtC9jaVr4RFeR VPcWBdfEH+jp3SgOEWllm4xiWMv2mzFNq+li0NYIw1a1vr6clrYyuQh914oh83/8tlmITFZM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241250 Archived-At: On Sun, 20 Oct 2019 10:46:10 -0400 (EDT) ergus@savannah.gnu.org (Jimmy Agu= ilar Mena) wrote: > branch: master > commit 270ca8c2735cfc7935b9e4d0b770a55138493ef3 > Author: Jimmy Aguilar Mena > Commit: Jimmy Aguilar Mena > > Fix internal-lisp-face-attributes to match face. > > * lisp/face-remap.el (internal-lisp-face-attributes): Updated the ^^^^^^^ The conventional practice is to use the imperative form of verbs in commit messages (so here "Update"). (I couldn't find documentation of this practice -- unlike for doc strings in (info "(elisp) Documentation Tips") -- but you'll see it in most commit messages.) > vector members to match the real member names. (Bug#37806) (Bug#3782= 4) > --- > lisp/face-remap.el | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lisp/face-remap.el b/lisp/face-remap.el > index 5cdecb9..f2ff2ec 100644 > --- a/lisp/face-remap.el > +++ b/lisp/face-remap.el > @@ -64,12 +64,14 @@ > ;; Names of face attributes corresponding to lisp face-vector positions= . > ;; This variable should probably be defined in C code where the actual > ;; definitions are available. > +;; :vector must be always at the end as a guard I don't think this is true for this vector, since it's only the length that's used here. (It is of course true for the enum LFACE_ATTRIBUTE_INDEX, which internal-lisp-face-attributes is meant to mirror, even though it doesn't use its content.) > ;; > (defvar internal-lisp-face-attributes > [nil > - :family :foundry :swidth :height :weight :slant :underline :inverse > - :foreground :background :stipple :overline :strike :box > - :font :inherit :fontset :vector]) > + :family :foundry :width :height :weight :slant :underline > + :inverse-video > + :foreground :background :stipple :overline :strike-through :box > + :font :inherit :fontset :distant-foreground :extend :vector]) For the same reason the attribute names here are not important (that's why :swidth and :inverse, and the absence of :distant(-foreground), didn't matter before). Indeed, I think :swidth was used instead of :width because the model for internal-lisp-face-attributes was the enum LFACE_ATTRIBUTE_INDEX, not the Lisp face attribute keywords defined in xfaces.c. I think that's also why internal-lisp-face-attributes begins with nil, so that the indices of the remaining elements match those of LFACE_ATTRIBUTE_INDEX; for it's use in face-remap.el, that element is superfluous. These remarks will probably become irrelevant when you replace internal-lisp-face-attributes with a vector defined in C in terms of the attribute keywords in xfaces.c. Steve Berman