From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Tue, 10 Dec 2019 01:45:18 +0200 Organization: LINKOV.NET Message-ID: <87eexdoygh.fsf@mail.linkov.net> References: <8736e3vve8.fsf@gmx.net> <8736e2coyv.fsf@mail.linkov.net> <83y2vujd0y.fsf@gnu.org> <87blspm0sm.fsf@mail.linkov.net> <837e3ckbem.fsf@gnu.org> <871rtjn0kt.fsf@mail.linkov.net> <83lfrrigj8.fsf@gnu.org> <87eexiqps5.fsf@mail.linkov.net> <83lfrphp94.fsf@gnu.org> <87wob7g2jk.fsf@mail.linkov.net> <83k177ebs0.fsf@gnu.org> <87muc27prn.fsf@mail.linkov.net> <83tv6acgq5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="237741"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 38457@debbugs.gnu.org, stephen.berman@gmx.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 10 00:56:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ieSsx-000zgj-Fa for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2019 00:56:15 +0100 Original-Received: from localhost ([::1]:48500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieSsv-0006lJ-Is for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2019 18:56:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieSsl-0006l7-SO for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 18:56:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieSsj-0007BY-RN for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 18:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieSsj-0007BU-OE for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 18:56:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieSsj-00018b-Nk for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 18:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Dec 2019 23:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.15759357234310 (code B ref 38457); Mon, 09 Dec 2019 23:56:01 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 9 Dec 2019 23:55:23 +0000 Original-Received: from localhost ([127.0.0.1]:54584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieSs7-00017S-6J for submit@debbugs.gnu.org; Mon, 09 Dec 2019 18:55:23 -0500 Original-Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:25971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieSs5-00017A-29 for 38457@debbugs.gnu.org; Mon, 09 Dec 2019 18:55:21 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E5F102C0A3E; Mon, 9 Dec 2019 23:55:19 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a95.g.dreamhost.com (100-96-92-172.trex.outbound.svc.cluster.local [100.96.92.172]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 692C02C0D46; Mon, 9 Dec 2019 23:55:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a95.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 09 Dec 2019 23:55:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Celery-Squirrel: 6ccc222773619cc9_1575935719711_2959410946 X-MC-Loop-Signature: 1575935719710:363169154 X-MC-Ingress-Time: 1575935719710 Original-Received: from pdx1-sub0-mail-a95.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a95.g.dreamhost.com (Postfix) with ESMTP id 6F47A9BAE1; Mon, 9 Dec 2019 15:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=iRIdYBBKLesc7UP+0EXpi+shU6c=; b= mpxJIzaHyBAfSgCJKHomYCs0rB7Qo1U75NWru8PjhXwHnQe89zmrgms5BrNIl1GI 6+i7hFDqKjHZrKyEVEgcN/bY3avMNpGTgmyfxueFp0IlRr9BBrLjCzEDVOb/nav8 Diu6k0AR79kMgmloBUfkVW09M7AZbe84qUmVYT+OU44= Original-Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a95.g.dreamhost.com (Postfix) with ESMTPSA id 483569B61E; Mon, 9 Dec 2019 15:55:14 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a95 In-Reply-To: <83tv6acgq5.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Dec 2019 05:36:50 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudelvddgudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173124 Archived-At: >> No, it was not only about y-or-n-p, but about any command that uses the minibuffer. > > As it turns out, not any command, because "M-x" and "C-x C-f" also use > the minibuffer. > > And the original bug reports definitely were about y-or-n-p. bug#34614 was not about y-or-n-p. It was about any command that uses the minibuffer. > I don't see how this is a "hack" when it uses the same technique as > your changes in 'message': checking a variable that is bound by other > functions. The advantage of my proposal is that it makes the new > functionality opt-in, so that any commands which need this could have > it by simply binding a variable, and would otherwise maintain its old > behavior, which was there for eons. Such variable already exists. It's called message-in-echo-area. You can enable it in the release branch if you want. But then please reopen bug#34614, bug#19064, bug#17272, bug#446. > Here's one more problem with the new behavior of 'message': > > emacs -Q > > Evaluate: > > (defun my-mesage () > (interactive) > (message "my most important message")) > (global-set-key [f5] 'my-mesage) > (setq debug-on-message "important") > > Press F5, observe the debugger pop up, as expected. > Type C-] to exit the debugger. > Type M-x, then press F5 => the debugger doesn't start, although the > message appears that should have triggered the debugger. This is exactly the purpose of the pretest - you are testing a new feature or a bug fix, then discover that some feature doesn't work, report it, and the following patch implements the missing feature. Looking at the recent log, there are many fixes in core functions with potentially destabilizing changes still committed every day. How fixes in minibuffer-message are different from other more risky fixes in other core functions? diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 8af8aca30e..125a711b54 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -749,7 +749,11 @@ minibuffer-message (put-text-property 0 1 'cursor t message)) (overlay-put ol 'after-string message) (sit-for (or minibuffer-message-timeout 1000000))) - (delete-overlay ol))))) + (delete-overlay ol))) + (when (and (stringp debug-on-message) + (stringp message) + (string-match-p debug-on-message message)) + (debug message)))) (defun minibuffer-completion-contents () "Return the user input in a minibuffer before point as a string.