From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#39546: 28.0.50; Do not require subr-x at run time Date: Mon, 10 Feb 2020 15:54:56 +0100 Message-ID: <87eev24hmn.fsf@gmx.de> References: <87k14uwnjl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120145"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39546@debbugs.gnu.org, lars magne ingebrigtsen , tassilo horn To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 10 15:57:02 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1AUf-000V8H-U1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 15:57:01 +0100 Original-Received: from localhost ([::1]:34730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1AUe-0002y4-Lp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 09:57:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1ATo-0002xu-Gz for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 09:56:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1ATl-00056i-AT for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 09:56:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1ATi-00054F-HF for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 09:56:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1ATi-0007h8-FM for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 09:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2020 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39546-submit@debbugs.gnu.org id=B39546.158134650828312 (code B ref 39546); Mon, 10 Feb 2020 14:56:02 +0000 Original-Received: (at 39546) by debbugs.gnu.org; 10 Feb 2020 14:55:08 +0000 Original-Received: from localhost ([127.0.0.1]:53939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1ASq-0007MY-1I for submit@debbugs.gnu.org; Mon, 10 Feb 2020 09:55:08 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:51761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1ASn-0007Ks-Rz for 39546@debbugs.gnu.org; Mon, 10 Feb 2020 09:55:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581346498; bh=mf0mH6JrtS2D86UH2028L3MuEstkyrb+Yq5Hyaogj+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=O0rcj0Lh2qokd7u+PgXu0GnfndJoTG3BCHbLZhaGyFKwR7y9aceerbymBH7CLIXm8 NoeeZ3waQOXwR32yWyzwRE+fR960c57KQUOKCCX+4mXvk7gz2AbFJtsisTIFUMZ2uf xcuQVsdjnPMkKvPTKNj80bCwCMxNDQTeXLv1v/4c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.51.13]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MV63g-1ituOC0rZO-00SAOa; Mon, 10 Feb 2020 15:54:58 +0100 In-Reply-To: <87k14uwnjl.fsf@gmail.com> (Tino Calancha's message of "Mon, 10 Feb 2020 14:59:42 +0100") X-Provags-ID: V03:K1:86cSrvzo4laidTbBqLgxOSEQj2cGVaKLAm12hPWEPBtWXMMnngY Z89rzdtRRfbB5Zi/0X0SoBPEv6MDyKZAPcLDkbBdS9CXrBMv7zq/MiuhNnHn8+Rx32EY9bo HX9kChjrI3Idc7aAGgPlPVmoL8s5WjaAjX3T0Zzk+9Q4YhK8fnj9bjciLevNdbgE4q2ugJ5 Ir2nAO6Yo4RcGsBlmhFdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:6vamxE47vYs=:rgVXmSevuDtI7zKIHqRj0r 89jXlWT1YtIdSSALEC6KuZ2RvQh91nbCopAnL5G05jfa4hpW6DFj3wD02Bs/KzJ6foGsK5/cq M237SOC4+/RoScUlNGBvImEejvjyhOghS1jDSgssP3/mE9yC/KYvqXt1R/K5y6FIN2ls8VVOu 3U3rw4hIbjk7l+xaqZlmXw9PAAgZLr3SCMhg74axkPkWUbxLZQhUKTePOX0NB7E3CsDLAWpaB bkVq36xaQWscieSP7J+HR5nuKkJDIKQrMEPYds3FIQjqeeDBs9y6hUd3J/jg7iA992+DynY8a zZ6KAnaOOvGPlMc5mYMl4MlD+A8eYml0Ah2ohGKa3MiU4fpmmsgga99UY5nLvGAWP62vYYLVr InXMkFUu3w1NuSedGMCS6a8dE/XxKl0w7M1vZrN/bLB6kCfahFjx+GicuDpEwR/UX2WEI0SVx IcRtxn/bnFjYFGXA0QBsmdBO8OhBsV9Q9yztCLitjR6iH6ODsoa/r+wsxZQfQpVDKwMQgWA1H a9euRtsG/QQ/1sjEwovD/ee/WivGBfOsV+IzXVT8/NU161Pb9I6zfFfpo28Cjffq/Q0K6AsX0 vdEAIjxP4up0Ck9a7u30TKcjmjx/DfSyM0JmZHc3WYcTYN/KcveiEWZLTTK/8EgINKvGin6ut FQwVeSdXYliW8cOASjuRbWdgMdfbcPS/H53vT51GVf+zGSb+zpivK79a4kxoXPcEXnTwdgCyL O57xK0/iS2qs226SaSNN2vyk+TM4IWw1qlNbmQb6XquGhMwq4xyVGS5YA5uDoxfPOGTJ3KYB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175868 Archived-At: Tino Calancha writes: Hi Tino, > diff --git a/lisp/net/tramp-compat.el b/lisp/net/tramp-compat.el > index 87bcd08b85..8f74683dee 100644 > --- a/lisp/net/tramp-compat.el > +++ b/lisp/net/tramp-compat.el > @@ -39,7 +39,7 @@ tramp-unload-file-name-handlers > (require 'ls-lisp) ;; Due to `tramp-handle-insert-directory'. > (require 'parse-time) > (require 'shell) > -(require 'subr-x) > +(eval-when-compile (require 'subr-x)) > > ;; `temporary-file-directory' as function is introduced with Emacs 26.1. > (declare-function tramp-handle-temporary-file-directory "tramp") Tramp needs `string-join' and `string-empty-p' from subr-x.el. If we don't load it here, we must eval-when-compile it in almost all Tramp files, I believe. Hmm, what's so bad requiring it? (I know the general answer because both are defsubst'es, but I don't see the point here).