From: Michael Albinus <michael.albinus@gmx.de>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 39546@debbugs.gnu.org, lars magne ingebrigtsen <larsi@gnus.org>,
tassilo horn <tsdh@gnu.org>
Subject: bug#39546: 28.0.50; Do not require subr-x at run time
Date: Mon, 10 Feb 2020 15:54:56 +0100 [thread overview]
Message-ID: <87eev24hmn.fsf@gmx.de> (raw)
In-Reply-To: <87k14uwnjl.fsf@gmail.com> (Tino Calancha's message of "Mon, 10 Feb 2020 14:59:42 +0100")
Tino Calancha <tino.calancha@gmail.com> writes:
Hi Tino,
> diff --git a/lisp/net/tramp-compat.el b/lisp/net/tramp-compat.el
> index 87bcd08b85..8f74683dee 100644
> --- a/lisp/net/tramp-compat.el
> +++ b/lisp/net/tramp-compat.el
> @@ -39,7 +39,7 @@ tramp-unload-file-name-handlers
> (require 'ls-lisp) ;; Due to `tramp-handle-insert-directory'.
> (require 'parse-time)
> (require 'shell)
> -(require 'subr-x)
> +(eval-when-compile (require 'subr-x))
>
> ;; `temporary-file-directory' as function is introduced with Emacs 26.1.
> (declare-function tramp-handle-temporary-file-directory "tramp")
Tramp needs `string-join' and `string-empty-p' from subr-x.el. If we
don't load it here, we must eval-when-compile it in almost all Tramp
files, I believe.
Hmm, what's so bad requiring it? (I know the general answer because both
are defsubst'es, but I don't see the point here).
next prev parent reply other threads:[~2020-02-10 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:59 bug#39546: 28.0.50; Do not require subr-x at run time Tino Calancha
2020-02-10 14:54 ` Michael Albinus [this message]
2020-02-10 17:35 ` Tino Calancha
2020-02-10 15:31 ` Eli Zaretskii
2020-02-10 17:26 ` Tino Calancha
2020-02-10 17:39 ` Eli Zaretskii
2020-02-10 19:19 ` Tassilo Horn
2020-02-10 19:59 ` Eli Zaretskii
2020-02-10 20:17 ` Tassilo Horn
2020-02-10 19:30 ` Tino Calancha
2020-02-10 19:54 ` Tassilo Horn
2020-02-10 20:34 ` Tino Calancha
2020-02-10 20:49 ` Tino Calancha
2020-02-10 21:00 ` Tino Calancha
2020-02-14 10:16 ` Eli Zaretskii
2020-02-19 13:41 ` Lars Ingebrigtsen
2020-08-08 14:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eev24hmn.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=39546@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=tino.calancha@gmail.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.