From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#39504: 27.0.60; [PATCH] eww/shr: Ensure faces of enclosing elements apply to elements Date: Fri, 21 Feb 2020 19:46:11 +0100 Message-ID: <87eeunixsc.fsf@gmail.com> References: <87zhdundsc.fsf@gmail.com> <87eeup5qru.fsf@gnus.org> <87wo8gsxzf.fsf@gmail.com> <87wo8g1523.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="129172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39504@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 19:47:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5DKc-000XS3-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 19:47:22 +0100 Original-Received: from localhost ([::1]:35090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5DKb-0006Rl-Tr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 13:47:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52049) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5DKM-0006QF-AE for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 13:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5DKK-00014Q-CG for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 13:47:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42140) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5DKH-00013m-QD for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 13:47:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5DKH-0008Gl-PF for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 13:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 39504-submit@debbugs.gnu.org id=B39504.158231078231737 (code B ref 39504); Fri, 21 Feb 2020 18:47:01 +0000 Original-Received: (at 39504) by debbugs.gnu.org; 21 Feb 2020 18:46:22 +0000 Original-Received: from localhost ([127.0.0.1]:48113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5DJe-0008Fp-IF for submit@debbugs.gnu.org; Fri, 21 Feb 2020 13:46:22 -0500 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:33613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5DJc-0008Fc-DA for 39504@debbugs.gnu.org; Fri, 21 Feb 2020 13:46:21 -0500 Original-Received: by mail-wm1-f68.google.com with SMTP id m10so5800054wmc.0 for <39504@debbugs.gnu.org>; Fri, 21 Feb 2020 10:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Wng2EFriFA8y40hE0xgWteCbhubQJxXqxUmbx/DT8WI=; b=gLJWQ3aDWXVhtDU6LQJwTDCX+hl/ynPAOyI5WZYAUZfOdStEKaMaSmrnhNe7K+clMR BPwqAeqvxylSc+YCyk+XUdn6yQG/XFnKx0zJuVBiM1OIqAb81/erc/F/Gr5HArLJr45W D6vimGAYGQepaJMgUpnPY3g9ahOutkbHhkECMoatzXflfI3mMM6dkGv8rl0f2Z8dBFIk 18bdKEp0XDv0FtMWZITClN9SWdrpyuU3mpHLruzDhcrv9YXra/tdbuatshyyDicoiR9R xIeke7q6Crt+gPJcARXzOKBmeDQ8xi1Zd5IbSJI9zwrdD30l3nrIhv0S2KVfmtKj9ota 1rCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Wng2EFriFA8y40hE0xgWteCbhubQJxXqxUmbx/DT8WI=; b=ImJ5N8a9vrqPjULw3vFu4w3yRy2KpnhbJw7bMC2eL66Tl6cMTBIv1u6wwmMQQdz/3s +be4T7z+KrIeyk1pDbnqs4bOEZqtaeZFJnwvkLoIkKRU1pAhBx0yH1hJccfV84t8bYj2 e6oGiF3MXqMOXWAsmomQMlOnsXfZKTQgZes0fbeM4GsyvfWIbdeQXAiat1EENRtkgF5W Wx9lSmy6Fgx0OZJxuqq0NHYwzTjVK1wOb724FBfB7cw8sM8PV1e+q5oYLyEgiGqoIhNe JIT1eVDp6Bg4PvxXovNyKhgn/FjUJed4FqiHE0yEnZb4Udp8aRcb1XsuPGf3nto9DI+j pxpg== X-Gm-Message-State: APjAAAWLNmOgHLmnvCSOLiSMyWloH6GjYT6C7rLxSwO+zEpS3WTt6XJq Ye3Is9kuiG5CsoQvKG0Lgqt2B5w9VuQ= X-Google-Smtp-Source: APXvYqzFgCJnF7y7C4i6JuhlGF3myrAfZDpKQghpyETZX8dfQE2J4Jp9pTYLShzLI1eXidgP/mk0Aw== X-Received: by 2002:a7b:c183:: with SMTP id y3mr5202898wmi.0.1582310774038; Fri, 21 Feb 2020 10:46:14 -0800 (PST) Original-Received: from hirondell ([109.190.253.11]) by smtp.gmail.com with ESMTPSA id e17sm5550946wrn.62.2020.02.21.10.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 10:46:12 -0800 (PST) In-Reply-To: <87wo8g1523.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Feb 2020 13:46:28 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176371 Archived-At: Lars Ingebrigtsen writes: >> Speaking of cosmetic issues, how did you apply my patch? > > I did it by hand since there were two patches in the email and the `M-m' > command in debbugs-gnu (which does all this applying and marking with > bug numbers automatically) doesn't like that. Thanks! I didn't know about debbugs-gnu's M-m. FWIW, "| git am RET" with point on the attachment actually *does* TRT[1] (so long as you're happy with the contributor's message). (Sorry for my earlier ramblings; while "git am $file" chokes on the leading '>', "git am < $file" digests it just fine.) I've cobbled up a function to apply "git am" on the attachment at point and let the committer optionally amend the message. Does that look useful? (defun debbugs-gnu-am () (gnus-mime-pipe-part "git am") (vc-checkin nil 'Git) (vc-git-log-edit-toggle-amend) ;; log-edit-done eventually errors out if vc-parent-buffer is not a ;; file-visiting buffer. (setq-local vc-parent-buffer (find-file-noselect "CONTRIBUTE"))) Granted, - the vc-parent-buffer hack is ugly, - this does not fill the *log-edit-files* buffer, - this does none of the careful window placement debbugs-gnu-apply-patch takes care of. [1] If default-directory is set to the root of the Emacs repository, but a cursory glance at debbugs-gnu-apply-patch gives me the feeling that it's also true there?