From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#39948: 28.0.50; crash in fchmodat Date: Sat, 07 Mar 2020 14:43:29 +0100 Message-ID: <87eeu4b7r2.fsf@gmx.net> References: <87mu8tin5g.fsf@gmx.net> <83tv31pjw6.fsf@gnu.org> <87h7z19fb1.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="26285"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39948@debbugs.gnu.org, Robert Pluim To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 07 14:44:58 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAZlB-0006jE-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 14:44:57 +0100 Original-Received: from localhost ([::1]:48900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAZlA-0003fp-CC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 08:44:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38717) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAZkK-0003fU-SA for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 08:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAZkJ-0008Df-Fv for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 08:44:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAZkI-0008D6-VL for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 08:44:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAZkI-00039x-To for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 08:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39948 X-GNU-PR-Package: emacs Original-Received: via spool by 39948-submit@debbugs.gnu.org id=B39948.158358863012099 (code B ref 39948); Sat, 07 Mar 2020 13:44:02 +0000 Original-Received: (at 39948) by debbugs.gnu.org; 7 Mar 2020 13:43:50 +0000 Original-Received: from localhost ([127.0.0.1]:46427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAZk5-000395-LG for submit@debbugs.gnu.org; Sat, 07 Mar 2020 08:43:49 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:36615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAZk4-00038r-7z for 39948@debbugs.gnu.org; Sat, 07 Mar 2020 08:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1583588611; bh=+uIRLHvSI/9LQAWQDzSrRKXA/tlmiZHK7TEMVktdUCQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Zkbn6ZPQx1PW7FbFoV6ave44BJ2HuxrdP8T44r9wKRoXlv9X+ouX/q44BLHDI32zB 3FagcYOnxoyl2MA//SrNAmDLz14nZowFElFUsljLXYpx/IJg965IvdP4C1yD8XlL9w r2Qm0gVYzdEb8yteHSYqT6C0uXqAWhGZLuwLfo24= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-lfs84 ([188.109.200.244]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N79yQ-1jQzfy3Xhc-017WWl; Sat, 07 Mar 2020 14:43:31 +0100 In-Reply-To: <87h7z19fb1.fsf@gmx.net> (Stephen Berman's message of "Sat, 07 Mar 2020 01:30:58 +0100") X-Provags-ID: V03:K1:KiJnjZRci4o+uDWJa9u9ZymNGJpYjTdybHdy6oJtYdmlbz5wDmz ye39YZcSPRra0xm3XZ6a0/I7Is4dnKb4E7xXlWG9tfUGqVg/jPvAk11IdQ8amkpNzkcgXOY rHDG33kiDAScmQaNwxw4qP767+l6/J0GdnKX4j8pZY8xzbJIh7gkPq6qEj9ErA9T0Kvvtsi H5dj0GyKhiTBlL34bXCLw== X-UI-Out-Filterresults: notjunk:1;V03:K0:bcRm4v9u9qs=:Ry3WdNkLhBNoBwjmih99+t VLc2GSe+vZMgg4+i7072NLV2sHYJwtb/nXLlMLtfK5JTq3J9Vn79XYCLskmsEu9o1XItYfCKf BeVRQSqZMylWM+cbCb9TF2Tgmglcl8oJOQxqV+QNuUqEWg759wzLydIhvRvjvGLjb25ag2Ibr KFrB8mc4VSSNp2K9aw7b5WX5x9Vbhvpchgfs7UVUT/fMypeI9ge6RUHJQu7NsI4VR2MjzlqK9 0crWqe9OVJdW4mEQ+dWa5eSo7Lii0RavSnU40d5/gPJXmGB4Nvee9kAzj+S5g7Bia3HJERaOV klLR2WwEECXYpiY8uF0UwMBHC/KHXmu4aOeeGy7z7Qsm0ccdAMM2GHS3QtgwztypkTgyZpt3Y qBsR5tp03SY81AmfUwZJq56wRapwFDJGos+9svnwjCsYsLQkzdEf9hzy+l63BGQgp2ndFU4pr rPAXr7SinDosu9XAelUfXRL/HfDhATW8zevA9FcqHuiq1hUiCWmgb2tjnvMLRvJBEsSlB0x7K F3dP69a+oRx69rig248Xs3xI+vMuO7mnKV/nQeTEYIg0yIHymTL7wWBjEWGrT2WnWam+u/M1o b1Ze0yZgX7aqw2RWX38DgQIhvZAcRnj+iP8A5+cUltn3rplPcgRiOm5tU2ohtFFUV9ZCeAmT5 EB+qWXcfMu4SKwg7iwFJxUQg/AFAedSSo0VEp6qKcQTbNlA3lZDXwbCEyv2xZA/ODlks7iN5i BHggqJ4ga0Fh5dnHth6zLAOgHSqCIupReMwlEmjo0Hjr2+HXc6WEF2gWZHxJ6YZUkWIfgZip X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177008 Archived-At: On Sat, 07 Mar 2020 01:30:58 +0100 Stephen Berman = wrote: > On Fri, 6 Mar 2020 15:54:07 -0800 Paul Eggert wrote: > >> On 3/6/20 8:45 AM, Robert Pluim wrote: >> >>> lib/fchmodat.c:fchmodat can call lib/fchmodat.c:orig_fchmodat, which >>> can call fchmodat. Presumably that last one is meant to be the system >>> fchmodat, but it=CA=BCs calling the fchmodat.c:fchmodat one instead. >> >> Yes, orig_fchmodat is supposed to call the system fchmodat. >> >> Do you get the same problem with 'make bootstrap'? If not, we're done. > > I was just about to shut down for the night when your mail arrived, so I > did `make bootstrap' but got the same crash both when sending a mail > with Gnus and when transfering a file with Tramp. I'll follow up on > your other suggestions on Saturday and report back. >> Otherwise, to help debug this please send the preprocessor output when >> compiling lib/fchmodat.c. Something like this: >> >> rm lib/fchmodat.o >> make V=3D1 >> Now, repeat the GCC command that compiles lib/fchmod.c, except use 'gcc = -E' >> instead of 'gcc -c'. >> >> Also, what are the values of HAVE_FCHMODAT (see src/config.h), and of >> GNULIB_FCHMODAT and REPLACE_FCHMODAT (look at the output of the command= =20 >> 'diff -u lib/sys_stat.in.h lib/sys/stat.h')? Also, please double-check >> lib/gnulib.mk for those three values. >> >> From your symptoms I would guess for you HAVE_FCHMODAT and GNULIB_FCHMOD= AT are >> 1 but REPLACE_FCHMODAT is 0. But if that's the case, your build shouldn'= t be >> compiling lib/fchmodat.c at all, because 'configure' says this: >> >> if test $HAVE_FCHMODAT =3D 0 || test $REPLACE_FCHMODAT =3D 1; then >> gl_LIBOBJS=3D"$gl_LIBOBJS fchmodat.$ac_objext" >> fi >> >> and so we need to investigate why this 'if' is being triggered, It appears that my OP was a false alarm. I build emacs out-of-tree but several months ago I ran `make TAGS' in the source directory and that seems to have also compiled the files in the source lib/, since it contained object files dated from that time. Is it possible that these were used when building in the build directory? Anyway, I ran `make distclean' in the Emacs source directory and also in the lib/ build directory, then reconfigured and rebuilt Emacs, and now I no longer get the crash. Unfortunately, I rashly did this before trying out your other suggestions, so I no longer have the previous state to check. But I can at least confirm that HAVE_FCHMODAT, GNULIB_FCHMODAT and REPLACE_FCHMODAT are (now) all set to 1. I'll keep running with this build and if the crash does not happen anymore, I'll close the bug later today or tomorrow, unless someone wants further testing or clarification. Thanks for the helpful feedback. Steve Berman