From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) Date: Fri, 24 Apr 2020 03:45:56 +0200 Message-ID: <87eesdmw39.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 23621@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 24 04:56:57 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRoWO-000Onz-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Apr 2020 04:56:56 +0200 Original-Received: from localhost ([::1]:48036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRoWN-00051O-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Apr 2020 22:56:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36846) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRoVe-00051E-9Y for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 22:56:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRoVb-0005FW-Fs for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 22:56:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRoVX-00054h-7f for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 22:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRoVW-0000m3-Gb for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 22:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Apr 2020 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 23621-submit@debbugs.gnu.org id=B23621.15876969142888 (code B ref 23621); Fri, 24 Apr 2020 02:56:02 +0000 Original-Received: (at 23621) by debbugs.gnu.org; 24 Apr 2020 02:55:14 +0000 Original-Received: from localhost ([127.0.0.1]:56136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoUk-0000kW-AW for submit@debbugs.gnu.org; Thu, 23 Apr 2020 22:55:14 -0400 Original-Received: from mout.web.de ([212.227.15.3]:47507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoUh-0000k9-Sb for 23621@debbugs.gnu.org; Thu, 23 Apr 2020 22:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587696904; bh=Hr+ANAUulAfm3SDdv81CHdgQGFKau89fqA2pySgrprQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:Date:References; b=HN8HV+6bLCt0lwBhqJJAkOgjx7M64T1FvtiCM07ZeyGLwann/rZyp+9BykwwnCVzm dMEwyvWtmCdSHICHAyYTh/ZIf17tFPKWNsHatLJHQUakdtVWR9N4HYfJupAXE4R0I9 y7b2400uhamwM2XfxrmYNfxDH6UyIQ5Yf2tLCIFk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQ5zf-1jVvER230N-005Li0; Fri, 24 Apr 2020 04:55:04 +0200 In-Reply-To: (Tino Calancha's message of "Fri, 27 May 2016 01:40:47 +0900 (JST)") Original-Lines: 14 X-Provags-ID: V03:K1:QRnwPtpQhiVQYsCgNqVae6Y6mbOdGNbzKkk6riAAcYvw8k65/At j6OMhsFunJRnNIfMIaGMf6vZXCsQlKvrZTr18gAuu7MSb5w4T0yCz8OJ0KLdWEDUAOv4c95 RthuBuGA4xHw5tgvCp0pBqHNkXNXSUuZ6y7R7dIXyTVDwrqZ7hHYKNXTUiltYVER5BMqxih USoGlQJU2jwlXU0P0M7Kw== X-UI-Out-Filterresults: notjunk:1;V03:K0:cW/AgorffpU=:oVuUwCuNrdIo5ZEi7PSC7d EcWKxRnY8+KRCBdEC30BctFhRX2y60s3pgOrK/kb0XDMfN192KrTGgkClAUpusocvu6DaUbyV qgw1oCbeTVfOlRhsLkmiY4rBT9VhiH5AsZcKlxKM4CQ/RCYfuZNQgDfORLAiRSaBMQ2SjCNb3 qiFrK/7kXVAcgvFT6ZgVmn1a2OxVZ48M2lin64HPDqn8XOdBBxpNDxTf78CxmTK6I2mgz2my1 lcK3vZxsCTrV+63x01rrxVI3jXIGsCizBR/8DSZ5gxx5HdRvwvcPEzGHcmP6vuFI1at9ooIcy tRWb6N1TSwhp/tytlKDlwckFUyFrXkz6u1E1Lio4JtU3x/eZfV3I4x4aSyD1YRcCjFFXxQd/k 7PwjBlhAI4vdf7+HOsrSihiW/ztBIfbUwHRgiWQzZowWNNU22U7UVOxBW+fW1F76TNzb2jZLy ZhM0Kuiy/So46t8ZGkPNoAZo2xTsTxuXFAa3YI8BuJ+ZAPy2VTG+0XtLXdkP9fErDeh+GcoBT PbEqHwOddEnScJZ0dS34TZ+fxKhAriw1q8jKiBp9HLaianyXfFzaOfr9Ki9xYdhvTng49/KFu 0XIjHkTqUxwbRZav3aZsijoluAMh8YD87rTTXFAsD8pEPeS3dE7dVMkBLa5nxYAFYx9+kg+L9 FhypRfxjIrUAh3HP6ylxk8u0EQRQ6uFcM+/qcOzgKY8GpXpa/vb5+/2z5Nm+UNcLOGiatlrP3 O442KvTO6IqyQAV6pG+ntmihq8g7869uXlmrj8vmuXraIrE602BDwjPK+OOvn7nqgh2Hix1d X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178881 Archived-At: Tino Calancha writes: > Allow winner-undo to restore the buffer point from deleted > windows (Bug#23621). > * lisp/window.el (window--before-delete-windows): New defun. > (delete-window, delete-other-windows): Use it. Seems your patch works only partially because it actually changed `minimize-window' instead of `delete-other-windows'. Was it by mistake? I also have a question: why do we need this at all? Is it because the window configuations saved are pushed when e.g. a window is split, but only afterwards the user changes point etc, then a window is closed, and when that's undone, without the patch, the originally saved window configuration contains the initial, useless positions, because the snapshot had actually been taken "too soon"? If that is the case - we now have `compare-window-configurations' that compares modulo value of point and such. Wouldn't it be simpler to teach delete-window e.a. to update the head window configuration in the frame's entry of winner-ring-alist with the current version before a window is deleted? TIA, Michael.